-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable failing DNS tests on SLES #48759
Conversation
As there's currently no infrastructure to disable just for SLES, disabling for its parent, which is Linux.
Tagging subscribers to this area: @dotnet/ncl Issue DetailsAs there's currently no infrastructure to disable just for SLES, cc @dotnet/ncl
|
We can't add an IsSles like we do for other distros? runtime/src/libraries/Common/tests/TestUtilities/System/PlatformDetection.Unix.cs Lines 17 to 31 in 2be64db
|
Feel free to update the PR with your suggestion. I'm on the phone and won't have access to my PC the next few hours. |
With infrastructure I meant the platform detection in XUnitExtensions so that it can be applied to an ActiveIssueAttribute. |
Can someone please approve? The failures are showing up on every PR that runs these tests (on SLES). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks ok for the emergency.
I will follow-up on this separately.
As there's currently no infrastructure to disable just for SLES,
disabling for its parent, which is Linux.
#48751
cc @dotnet/ncl