Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add progressbar to SuperPMI.py script #48649

Merged
merged 2 commits into from
Feb 23, 2021
Merged

Add progressbar to SuperPMI.py script #48649

merged 2 commits into from
Feb 23, 2021

Conversation

EgorBo
Copy link
Member

@EgorBo EgorBo commented Feb 23, 2021

For some reason it's super slow for me (it downloads a lot of data) so a download status reporter is nice to have

image

/cc @BruceForstall

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Feb 23, 2021
BruceForstall
BruceForstall approved these changes Feb 23, 2021
View reviewed changes
Copy link
Member

@BruceForstall BruceForstall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very cool; LGTM

@EgorBo EgorBo merged commit 2c8f2dc into dotnet:master Feb 23, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Mar 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BruceForstall BruceForstall BruceForstall approved these changes

Assignees
No one assigned
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EgorBo @BruceForstall