Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mono] Implement IgnoresAccessChecksToAttribute support #48558

Merged
merged 4 commits into from
Feb 27, 2021

Conversation

lambdageek
Copy link
Member

System.Runtime.CompilerServices.IgnoresAccessChecksToAttribute is like the reverse of
InternalsVisibleTo - it's added to an assembly to indicate that that
assembly can call non-public methods from the specified assembly.

The interesting thing is that the DynamicProxy dynamically generates
the attribute, so it is not explicitly declared in CoreLib.

Fixes #47989

@ghost
Copy link

ghost commented Feb 20, 2021

Tagging subscribers to this area: @CoffeeFlux
See info in area-owners.md if you want to be subscribed.

Issue Details

System.Runtime.CompilerServices.IgnoresAccessChecksToAttribute is like the reverse of
InternalsVisibleTo - it's added to an assembly to indicate that that
assembly can call non-public methods from the specified assembly.

The interesting thing is that the DynamicProxy dynamically generates
the attribute, so it is not explicitly declared in CoreLib.

Fixes #47989

Author: lambdageek
Assignees: -
Labels:

area-VM-meta-mono

Milestone: -

@lambdageek lambdageek added area-VM-reflection-mono Reflection issues specific to MonoVM and removed area-VM-meta-mono labels Feb 20, 2021
@ghost
Copy link

ghost commented Feb 20, 2021

Tagging subscribers to this area: @CoffeeFlux
See info in area-owners.md if you want to be subscribed.

Issue Details

System.Runtime.CompilerServices.IgnoresAccessChecksToAttribute is like the reverse of
InternalsVisibleTo - it's added to an assembly to indicate that that
assembly can call non-public methods from the specified assembly.

The interesting thing is that the DynamicProxy dynamically generates
the attribute, so it is not explicitly declared in CoreLib.

Fixes #47989

Author: lambdageek
Assignees: -
Labels:

area-System.Reflection-mono

Milestone: -

@lambdageek lambdageek added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Feb 23, 2021
@lambdageek lambdageek removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Feb 25, 2021
@lambdageek lambdageek force-pushed the add-ignores_access_checks_to branch from 7e4e590 to 708a502 Compare February 25, 2021 21:10
lambdageek and others added 4 commits February 26, 2021 14:17
System.Runtime.CompilerServices.IgnoresAccessChecksToAttribute is like the reverse of
InternalsVisibleTo - it's added to an assembly to indicate that that
assembly can call non-public methods from the specified assembly.

The interesting thing is that the DynamicProxy dynamically generates
the attribute, so it is not explicitly declared in CoreLib.

Fixes dotnet#47989
check that calling private/internal methods in another assembly throws.
check that calling a private method in the same assembly throws.
@lambdageek lambdageek force-pushed the add-ignores_access_checks_to branch from 708a502 to bdf249e Compare February 26, 2021 20:13
@lambdageek lambdageek merged commit 9102b07 into dotnet:master Feb 27, 2021
@krwq
Copy link
Member

krwq commented Mar 1, 2021

Thank you @lambdageek!

@lambdageek lambdageek deleted the add-ignores_access_checks_to branch March 1, 2021 14:04
@ghost ghost locked as resolved and limited conversation to collaborators Mar 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-VM-reflection-mono Reflection issues specific to MonoVM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[mono] Add support for IgnoresAccessChecksToAttribute
3 participants