Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NotNullWhen(true) on Directory/File.Exists #47579

Merged
merged 2 commits into from
Jan 28, 2021

Conversation

huoyaoyuan
Copy link
Member

Closes #47573 .

Note: there were already annotations on ref of Directory and impl on File. Doesn't ApiCompact check this?

@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@stephentoub
Copy link
Member

there were already annotations on ref of Directory and impl on File. Doesn't ApiCompact check this?

@ericstj, @safern?

@huoyaoyuan huoyaoyuan force-pushed the directory-file-exists branch from 34c66e6 to aef3041 Compare January 28, 2021 16:27
@stephentoub stephentoub merged commit eba5b50 into dotnet:master Jan 28, 2021
@huoyaoyuan huoyaoyuan deleted the directory-file-exists branch January 29, 2021 04:36
@safern
Copy link
Member

safern commented Jan 29, 2021

APICompat doesn't have a way to check nullable annotations yet, however we do plan on fixing this for the 6.0.0 release. Attribute differences should be flagged by APICompat just fine.

@ghost ghost locked as resolved and limited conversation to collaborators Mar 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Directory.Exists and File.Exists annotated parameter with [NotNullWhen(true)]
3 participants