Fix the GenericTest.Vector*Boolean

[sandreenko]

Bool need special marshaling attribute, the test was failing on arm64 apple
where C++ was expecting them to be packed as 1 byte.

Thanks, @jkoritzinsky for helping with this.

[dotnet-issue-labeler]

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

[sandreenko]

cc @sdmaclea, @janvorli , @mangod9

[sandreenko]

I think it was the lest test that was failing constantly in my local runs (with #46665 applied)

[sdmaclea]

I am not sure this is the right fix. As this requires all C# code to be changed to work with Apple Silicon. Maybe the default marshalling of C# bool on Apple Silicon needs to be changed instead?

It seems like we should have a stable cross platform expectation C# <-> C++ mapping across platforms. Although in general C++ types do not have defined sized, there are newer types with well defined and stable size across platforms. i.e int8_t ... int64_t and uint8_t ... uint64_t

[jkoritzinsky]

This fix fixes a bug that was on all platforms that we just hadn’t noticed. The previous code was semantically wrong in all cases and just happened to work.

[tannergooding]

The previous code was semantically wrong in all cases and just happened to work.

Yep, my bad 😄. I always forget that bool is int by default, even on non-Windows (this also why I explicitly use byte and int in my own P/Invoke code >.>).