Allow CreateInstanceForAnotherGenericParameter to take multi args #45085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkotas
reviewed
Nov 23, 2020
src/coreclr/src/System.Private.CoreLib/src/System/RuntimeHandles.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Nov 23, 2020
|
I can back out the commit 5a6682d and send it as another PR if desired. But this PR seemed like a decent place to put it since I was touching those files anyway. |
jkotas
reviewed
Nov 23, 2020
jkotas
approved these changes
Nov 23, 2020
|
Thanks for the review! I'll leave it open for another day or so in case the other reviewers want to chime in. |
steveharter
reviewed
Nov 23, 2020
steveharter
reviewed
Nov 23, 2020
steveharter
approved these changes
Nov 23, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on a comment at https://github.com/dotnet/runtime/pull/32520/files#r451611457. This PR adds another overload to
CreateInstanceForAnotherGenericParameterso that the caller can pass 2 parameters instead of just one. I've also hooked it up throughArraySortHelperso that it avoids the call toRuntimeTypeHandle.Allocate. This also allows #32520 to cleanly delete theRuntimeTypeHandle.Allocatemethod.Also converts the unmanaged side to a QCALL, because why not.
Alternative design
I could introduce a method that takes
params RuntimeType[] genericArgs. If we did this, it should have a defensive copy in order to guard against mutation (see changes inRuntimeTypeHandle.Instantiate, also in this PR). I figured that there wasn't a real need to add this just yet since the simplest thing to do for now was to add the 2-param overload. The unmanaged side is already set up now to take as many parameters as needed, so any future changes here can be fully managed.