Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for issue 40444 - Thread.MemoryBarrier() should prevent hoisting of memory reads #40821

Merged
merged 1 commit into from
Aug 14, 2020
Merged

Fix for issue 40444 - Thread.MemoryBarrier() should prevent hoisting of memory reads #40821

merged 1 commit into from
Aug 14, 2020

Conversation

briansull
Copy link
Contributor

Add the GT_MEMORYBARRIER operator to the set of instructions that need to record a ByrefExposed memory havoc impact in loops

This prevents the hoisting of memory loads out of such a loop

@briansull
Add the GT_MEMORYBARRIER operator to the set of instructions that nee…
f3f8e03 
…d to record a ByrefExposed memory havoc impact in loops

This prevents the hoisting of memory loads out of such a loop
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Aug 14, 2020
@briansull
Copy link
Contributor Author

Fixes #40444

@briansull
Copy link
Contributor Author

@AndyAyersMS PTAL
@dotnet/jit-contrib

AndyAyersMS
AndyAyersMS approved these changes Aug 14, 2020
View reviewed changes
Copy link
Member

@AndyAyersMS AndyAyersMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@jaredpar jaredpar mentioned this pull request Aug 14, 2020
Closed
@briansull briansull merged commit 978b39b into dotnet:master Aug 14, 2020
@briansull briansull mentioned this pull request Aug 14, 2020
Closed
@jkotas jkotas mentioned this pull request Aug 15, 2020
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AndyAyersMS AndyAyersMS AndyAyersMS approved these changes

Assignees
No one assigned
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@briansull @AndyAyersMS @Dotnet-GitSync-Bot