Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ReferenceConverter entry to intrinsic type converters table #39854

Merged
merged 2 commits into from
Jul 24, 2020

Conversation

safern
Copy link
Member

@safern safern commented Jul 23, 2020

Fixes: #34709

cc: @DustinCampbell

@safern safern requested a review from ericstj July 23, 2020 19:02
@Dotnet-GitSync-Bot
Copy link
Collaborator

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost
Copy link

ghost commented Jul 23, 2020

Tagging subscribers to this area: @safern
See info in area-owners.md if you want to be subscribed.

@safern
Copy link
Member Author

safern commented Jul 23, 2020

WASM failures are: #39473

@safern safern merged commit e65c309 into dotnet:master Jul 24, 2020
@safern safern deleted the AddReferenceConverterToReflectDescriptor branch July 24, 2020 06:13
Jacksondr5 pushed a commit to Jacksondr5/runtime that referenced this pull request Aug 10, 2020
…et#39854)

* Add ReferenceConverter entry to intrinsic type converters table

* Add tests
@karelz karelz added this to the 5.0.0 milestone Aug 18, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ReflectTypeDescriptorProvider fails to add ReferenceConverter to intrinsic converter table
4 participants