-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Widen ascii to utf16 #39510
Widen ascii to utf16 #39510
Conversation
f5b7a06
to
9aeccb9
Compare
Tagging subscribers to this area: @tannergooding |
src/libraries/System.Private.CoreLib/src/System/Text/ASCIIUtility.cs
Outdated
Show resolved
Hide resolved
Same here. Please add the benchmark in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (with nits)
src/libraries/System.Private.CoreLib/src/System/Text/ASCIIUtility.cs
Outdated
Show resolved
Hide resolved
Thanks for the reviews @eiriktsarpalis @echesakovMSFT and @kunalspathak |
CI failures are unrelated. Merging |
Could you double check the benchmark |
Yup, it's hitting the code path. I added an exception that triggered by the benchmarking code:
|
Ready for review now.
Implements WidenAsciiToUtf16 from #35034
Perf: