Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new properties for Obsolete Attribute #33248

Merged
merged 6 commits into from
Mar 6, 2020
Merged

Add new properties for Obsolete Attribute #33248

merged 6 commits into from
Mar 6, 2020

Conversation

buyaa-n
Copy link
Contributor

@buyaa-n buyaa-n commented Mar 5, 2020 •
edited
Loading

Add DiagnosticId, UrlFormat properties for Obsolete Attribute
Related to #33089

@buyaa-n buyaa-n added this to the 5.0 milestone Mar 5, 2020
@buyaa-n buyaa-n requested review from terrajobst and danmoseley March 5, 2020 17:44
@Dotnet-GitSync-Bot
Copy link
Collaborator

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@stephentoub
Copy link
Member

Before we actually merge these in, do we have buy-off that the compilers will respect them appropriately?
cc: @terrajobst

terrajobst
terrajobst approved these changes Mar 5, 2020
View reviewed changes
Copy link
Contributor

@terrajobst terrajobst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API changes look good

@terrajobst
Copy link
Contributor

terrajobst commented Mar 5, 2020 •
edited
Loading

Before we actually merge these in, do we have buy-off that the compilers will respect them appropriately?
cc: @terrajobst

@jaredpar and @agocke agreed based on my spec. The Roslyn work is tracked here: dotnet/roslyn#42119, F# is tracked here dotnet/fsharp#8654.

@buyaa-n buyaa-n merged commit 0c04241 into dotnet:master Mar 6, 2020
@buyaa-n buyaa-n deleted the obsolete_attribute branch March 6, 2020 00:46
@terrajobst terrajobst mentioned this pull request Mar 6, 2020
Closed
This was referenced Mar 9, 2020
Closed
Closed
@Joe4evr Joe4evr mentioned this pull request Apr 8, 2020
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@danmoseley danmoseley danmoseley left review comments

@jkotas jkotas jkotas left review comments

@terrajobst terrajobst terrajobst approved these changes

Assignees
No one assigned
Labels
area-System.Runtime new-api-needs-documentation
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.
6 participants
@buyaa-n @Dotnet-GitSync-Bot @stephentoub @terrajobst @danmoseley @jkotas