Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a script for generating a .sln containing all library projects #186

Merged
merged 2 commits into from
Nov 22, 2019
Merged

Add a script for generating a .sln containing all library projects #186

merged 2 commits into from
Nov 22, 2019

Conversation

stephentoub
Copy link
Member

No description provided.

@ViktorHofer
Copy link
Member

So you actually checked in the sln as well. Was that intended?

@stephentoub
Copy link
Member Author

Was that intended?

It was. You'd prefer I not?

@ViktorHofer
Copy link
Member

It was. You'd prefer I not?

I thought you just wanted to provide the script to generate it on the fly. I'm fine with checking it in but I'm a bit worried about the noise that comes with it (the VS version stamp in it).

@ViktorHofer
Copy link
Member

What about .gitignoring it so that we require a git add --force to update it?

@stephentoub
Copy link
Member Author

I thought you just wanted to provide the script to generate it on the fly. I'm fine with checking it in but I'm a bit worried about the noise that comes with it (the VS version stamp in it).

My thinking was I (and anyone else who wanted to use it) would use the .sln, but then as things changed, run the script again to regenerate it from time to time.

But if you're concerned about noise, I can just not check it in and just run the script each time I need it.

@ViktorHofer
Copy link
Member

If we provide three slns for ref, src and tests we can cover most of the code in libraries. I haven't tried it yet but if I can have those three open at the same time that would be a real productivity boost (for those who use VS and not VSCode). I'm fine with checking these in but I would prefer to also add .gitignore entries for them.

@stephentoub
Copy link
Member Author

I deleted the generated .sln and updated the script to support generating for src, ref, or tests.

@stephentoub stephentoub merged commit da1b717 into dotnet:master Nov 22, 2019
@stephentoub stephentoub deleted the librariessln branch November 22, 2019 03:56
@karelz karelz added this to the 5.0.0 milestone Aug 18, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants