Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark Value/HasValue/GetValueOrDefault members of Nullable<T> as readonly #1727

Merged
merged 1 commit into from
Jan 15, 2020
Merged

Mark Value/HasValue/GetValueOrDefault members of Nullable<T> as readonly #1727

merged 1 commit into from
Jan 15, 2020

Conversation

ltrzesniewski
Copy link
Contributor

Fixes #836

@ltrzesniewski
Mark some Nullable<T> members as readonly
86c2f66 
Value, HasValue, GetValueOrDefault
@GrabYourPitchforks
Copy link
Member

The CI failure is unrelated and is being tracked by #1729.

@jkotas jkotas mentioned this pull request Jan 15, 2020
Closed
@jkotas jkotas merged commit 92025b2 into dotnet:master Jan 15, 2020
@ltrzesniewski ltrzesniewski deleted the nullable-readonly branch January 15, 2020 07:45
@tannergooding tannergooding mentioned this pull request Jan 21, 2020
Open
@ghost ghost locked as resolved and limited conversation to collaborators Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@GrabYourPitchforks GrabYourPitchforks GrabYourPitchforks approved these changes

@tannergooding tannergooding tannergooding approved these changes

Assignees
No one assigned
Labels
area-System.Runtime
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mark Value and HasValue of System.Nullable<T> as readonly
5 participants
@ltrzesniewski @GrabYourPitchforks @tannergooding @maryamariyan @jkotas