JIT: Delete old GenTreeCall ABI information
#112665
Conversation
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
| if (setupArg->OperIsCopyBlkOp()) | ||
| { | ||
| setupArg = comp->fgMorphCopyBlock(setupArg); | ||
| #if defined(TARGET_ARMARCH) || defined(UNIX_AMD64_ABI) || defined(TARGET_LOONGARCH64) || defined(TARGET_RISCV64) | ||
| if ((lclVarType == TYP_STRUCT) && (arg.AbiInfo.ArgType != TYP_STRUCT)) | ||
| { | ||
| scalarType = arg.AbiInfo.ArgType; | ||
| } | ||
| #endif // TARGET_ARMARCH || defined (UNIX_AMD64_ABI) || defined(TARGET_LOONGARCH64) || defined(TARGET_RISCV64) | ||
| } | ||
|
|
||
| // scalarType can be set to a wider type for ARM or unix amd64 architectures: (3 => 4) or (5,6,7 => | ||
| // 8) | ||
| if ((scalarType != TYP_UNKNOWN) && (scalarType != lclVarType)) | ||
| { | ||
| // Create a GT_LCL_FLD using the wider type to go to the late argument list | ||
| defArg = comp->gtNewLclFldNode(tmpVarNum, scalarType, 0); | ||
|
|
||
| comp->lvaSetVarDoNotEnregister(tmpVarNum DEBUGARG(DoNotEnregisterReason::LocalField)); | ||
| } | ||
| else | ||
| { | ||
| // Create a copy of the temp to go to the late argument list | ||
| defArg = comp->gtNewLclvNode(tmpVarNum, lclVarType); | ||
| } |
There was a problem hiding this comment.
This is the cause of the few diffs. It means we have IR diffs like
- [000154] -----+----- arg20 in out+80 ├──▌ LCL_FLD ubyte V37 tmp16 [+0]
+ [000154] -----+----- arg20 out+80 ├──▌ LCL_VAR struct<ABIStress.S1P, 1> V37 tmp16 here, and the armarch backend seems to prefer an 8 byte load for this case over the 1 byte load (would probably be best to stick to the 1 byte load to avoid potential forwarding stalls, but that's something for another time)
There was a problem hiding this comment.
Do you mean gcinfo diffs? because it seems like your diffs are zero sized
There was a problem hiding this comment.
I meant diffs like this one:
|
cc @dotnet/jit-contrib PTAL @EgorBo Very minor diffs. Left a review comment on the code responsible for that. Otherwise just some TP improvements from no longer having to save the old ABI information. |
All uses of this should be gone now, so we can get rid of it.