-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use osx.13.arm64.open queue for osx testing #112647
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
/azp run runtime-nativeaot-outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
Should we bump the x64 variant as well? |
I've not seen problems with that queue so my gut says "don't touch what's not broken". I don't know what schedule we follow in upgrading these. I just know that we had problems with this queue since december when the number of machines dropped from 30 to 10 (dotnet/dnceng#4734) and I don't see anyone doing anything about this so I'm just trying to do something. |
Ok, thanks. |
Perhaps we should promote osx-arm64 to how much we are currently caring for (the declining) osx-x64 #108570 (Apple stopped producing x64 macs in 2023: second paragraph). |
@@ -105,7 +105,7 @@ jobs: | |||
# OSX arm64 | |||
- ${{ if eq(parameters.platform, 'osx_arm64') }}: | |||
- ${{ if eq(variables['System.TeamProject'], 'public') }}: | |||
- OSX.1200.ARM64.Open | |||
- osx.13.arm64.open | |||
- ${{ if eq(variables['System.TeamProject'], 'internal') }}: | |||
- OSX.1200.ARM64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bump this one too?
- OSX.1200.ARM64 | |
- osx.13.arm64 |
/azp run runtime-libraries-coreclr outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
System.Security.Cryptography.OpenSsl.Tests is running into SIGABRT on native AOT; that doesn't look very promising. I fired off libraries outerloop since by default we don't seem to test anything on arm64 macs and no other leg ran there. |
That's not entirely unexpected. macOS doesn't ship OpenSSL by default and the test prints |
It should be running this script: runtime/eng/pipelines/common/global-build-job.yml Lines 197 to 198 in 6e06aef
|
@am11 that is for the build machine, it doesn't apply to Helix IIRC openssl was manually installed on these machines by dnceng? |
Yup, I meant test machine can use the same script to install runtime dependencies. We are using it in multiple places in addition to build machines. |
I pinged @ilyas1974 and he'll have it looked into. |
Any reason why we can't bump to |
I assumed we have a preference for oldest possible macOS and then cross fingers about Apple's backwards compatibility. But I don't know our testing strategy for mac. |
The osx 12 queue only has a couple machines servicing it. Looks like osx 12 is already out of support by Apple so dnceng scaled it down?
This queue is the main reason why runtime-nativeaot-outerloop almost never succeeds despite my weeks long effort to get it green. E.g (https://helix.dot.net/api/jobs/226c27df-153e-4f75-9003-5dd5f5a355a2/workitems/System.Diagnostics.Tools.Tests?api-version=2019-06-17):
Six and a half hour wait time so we can run a three second job.
Per dotnet/dnceng#3008 (comment) the recommendation is to move to osx 14 queues but I'm trying with osx 13 since I assume our preference is as old as possible.
Cc @dotnet/runtime-infrastructure