Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use osx.13.arm64.open queue for osx testing #112647

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MichalStrehovsky
Copy link
Member

The osx 12 queue only has a couple machines servicing it. Looks like osx 12 is already out of support by Apple so dnceng scaled it down?

This queue is the main reason why runtime-nativeaot-outerloop almost never succeeds despite my weeks long effort to get it green. E.g (https://helix.dot.net/api/jobs/226c27df-153e-4f75-9003-5dd5f5a355a2/workitems/System.Diagnostics.Tools.Tests?api-version=2019-06-17):

  "Queued": "2025-02-17T23:02:28.573+00:00",
  "Started": "2025-02-18T05:34:09.794+00:00",
  "Finished": "2025-02-18T05:34:12.732+00:00",
  "Delay": "06:31:41.2210000",
  "Duration": "00:00:02.9380000",

Six and a half hour wait time so we can run a three second job.

Per dotnet/dnceng#3008 (comment) the recommendation is to move to osx 14 queues but I'm trying with osx 13 since I assume our preference is as old as possible.

Cc @dotnet/runtime-infrastructure

@Copilot Copilot bot review requested due to automatic review settings February 18, 2025 08:31
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Feb 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

@MichalStrehovsky
Copy link
Member Author

/azp run runtime-nativeaot-outerloop

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ivanpovazan
Copy link
Member

Should we bump the x64 variant as well?

@MichalStrehovsky
Copy link
Member Author

Should we bump the x64 variant as well?

I've not seen problems with that queue so my gut says "don't touch what's not broken". I don't know what schedule we follow in upgrading these. I just know that we had problems with this queue since december when the number of machines dropped from 30 to 10 (dotnet/dnceng#4734) and I don't see anyone doing anything about this so I'm just trying to do something.

@ivanpovazan
Copy link
Member

Ok, thanks.
We are experiencing timeouts on osx.1200.amd64 as well, for iOS platforms testing, so was wondering wether we should bump everything to osx.13 instead of gradually moving to the newer queue.

@am11
Copy link
Member

am11 commented Feb 18, 2025

x64 variant

Perhaps we should promote osx-arm64 to how much we are currently caring for (the declining) osx-x64 #108570 (Apple stopped producing x64 macs in 2023: second paragraph).

@@ -105,7 +105,7 @@ jobs:
# OSX arm64
- ${{ if eq(parameters.platform, 'osx_arm64') }}:
- ${{ if eq(variables['System.TeamProject'], 'public') }}:
- OSX.1200.ARM64.Open
- osx.13.arm64.open
- ${{ if eq(variables['System.TeamProject'], 'internal') }}:
- OSX.1200.ARM64
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bump this one too?

Suggested change
- OSX.1200.ARM64
- osx.13.arm64

@MichalStrehovsky
Copy link
Member Author

/azp run runtime-libraries-coreclr outerloop

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@MichalStrehovsky
Copy link
Member Author

System.Security.Cryptography.OpenSsl.Tests is running into SIGABRT on native AOT; that doesn't look very promising. I fired off libraries outerloop since by default we don't seem to test anything on arm64 macs and no other leg ran there.

@filipnavara
Copy link
Member

filipnavara commented Feb 18, 2025

System.Security.Cryptography.OpenSsl.Tests is running into SIGABRT on native AOT; that doesn't look very promising.

That's not entirely unexpected. macOS doesn't ship OpenSSL by default and the test prints No usable version of libssl was found which is followed by abort.

@am11
Copy link
Member

am11 commented Feb 18, 2025

It should be running this script:

- script: $(Build.SourcesDirectory)/eng/common/native/install-dependencies.sh ${{ parameters.osGroup }}
displayName: Install Build Dependencies

@akoeplinger
Copy link
Member

@am11 that is for the build machine, it doesn't apply to Helix

IIRC openssl was manually installed on these machines by dnceng?

@am11
Copy link
Member

am11 commented Feb 18, 2025

Yup, I meant test machine can use the same script to install runtime dependencies. We are using it in multiple places in addition to build machines.

@steveisok
Copy link
Member

@am11 that is for the build machine, it doesn't apply to Helix

IIRC openssl was manually installed on these machines by dnceng?

I pinged @ilyas1974 and he'll have it looked into.

@steveisok
Copy link
Member

Any reason why we can't bump to osx.15.arm64 and osx.15.arm64.open? We appear to have even more capacity there.

@MichalStrehovsky
Copy link
Member Author

Any reason why we can't bump to osx.15.arm64 and osx.15.arm64.open? We appear to have even more capacity there.

I assumed we have a preference for oldest possible macOS and then cross fingers about Apple's backwards compatibility. But I don't know our testing strategy for mac.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants