Fix assertion when capturing dump on ARM64 #112550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (2)
- src/coreclr/debug/createdump/memoryregion.h: Language not supported
- src/coreclr/debug/createdump/specialdiaginfo.h: Language not supported
|
Tagging subscribers to this area: @tommcdon |
This was referenced Feb 14, 2025
Open
mikem8361
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes an assertion fired on OSX/ARM64 while capturing a heap dump.
The problem is that on OSX/ARM64, the page size is 16k (instead of the usual 4k), so
SpecialDiagInfoSizeis not a multiple of the page size, theendwill not be page aligned.And by the time this special region get to
CombineMemoryRegions, it won't usually get combined with any existing region, but it itself is not page aligned, and so triggering the assertion.We aren't really writing the actual page to the dump anyway, might as well just assert the exact size for this particular region instead.
This change is only tested for OSX/ARM64, and it should have no retail impact (just failing for check/debug builds)