Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Remove CoreCLR functional tests on Android from extra-platforms #112496

Merged
merged 4 commits into from
Feb 13, 2025
Merged

[Android] Remove CoreCLR functional tests on Android from extra-platforms #112496

merged 4 commits into from
Feb 13, 2025

Conversation

kotlarmilos
Copy link
Member

Description

This PR removes a redundant job from extra-platforms. We we include the full libraries run in the extra-platforms.

Follow-up #112283

@Copilot Copilot bot review requested due to automatic review settings February 12, 2025 20:08
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Feb 12, 2025
Copilot
Copilot AI reviewed Feb 12, 2025
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
@kotlarmilos kotlarmilos self-assigned this Feb 12, 2025
@kotlarmilos kotlarmilos added area-Infrastructure-coreclr os-android and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Feb 12, 2025
@kotlarmilos kotlarmilos added this to the 10.0.0 milestone Feb 12, 2025
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

@kotlarmilos
Copy link
Member Author

/azp run runtime-androidemulator

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Feb 13, 2025
Open
Open
Open
Open
Open
Open
matouskozak
matouskozak approved these changes Feb 13, 2025
View reviewed changes
Copy link
Member

@matouskozak matouskozak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the update.

One thing, I'm not sure if we shouldn't include
eq(stageDependencies.EvaluatePaths.evaluate_paths.outputs['SetPathVars_coreclr.containsChange'], true), in

runtime/eng/pipelines/runtime.yml

Lines 991 to 994 in d94a04d

or(
eq(stageDependencies.EvaluatePaths.evaluate_paths.outputs['SetPathVars_libraries.containsChange'], true),
eq(stageDependencies.EvaluatePaths.evaluate_paths.outputs['SetPathVars_installer.containsChange'], true),
eq(variables['isRollingBuild'], true))

eng/pipelines/runtime.yml Outdated Show resolved Hide resolved
kotlarmilos and others added 2 commits February 13, 2025 09:30
@kotlarmilos @matouskozak
Update eng/pipelines/runtime.yml
8a9cd49 
Co-authored-by: Matous Kozak <55735845+matouskozak@users.noreply.github.com>
@kotlarmilos
Add SetPathVars_coreclr condition
68ce3f4
This was referenced Feb 13, 2025
Open
Open
Open
Open
@kotlarmilos kotlarmilos merged commit 4058c09 into dotnet:main Feb 13, 2025
147 of 151 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@steveisok steveisok steveisok approved these changes

@matouskozak matouskozak matouskozak approved these changes

@ivanpovazan ivanpovazan Awaiting requested review from ivanpovazan

Assignees

@kotlarmilos kotlarmilos

Labels
area-Infrastructure-coreclr os-android
Projects
Runtime Infra
Status: Done
Milestone
10.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@kotlarmilos @steveisok @matouskozak