[release/8.0-staging] Move generation of SuggestedBindingRedirects.targets to inner build #112494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…otnet#112379) * Move generation of SuggestedBindingRedirects.targets to inner build These targets depend on the AssemblyVersion of the library which is specific to the inner-build of the library. Generate them in the inner-build. * Update src/libraries/System.Resources.Extensions/src/System.Resources.Extensions.csproj
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (1)
- src/libraries/System.Resources.Extensions/src/System.Resources.Extensions.csproj: Language not supported
|
Tagging subscribers to this area: @dotnet/area-system-resources |
carlossanlop
approved these changes
Feb 19, 2025
|
/ba-g failures are all #112312 |
tarekgh
reviewed
Feb 19, 2025
| </Target> | ||
|
|
||
| <ItemGroup Condition="'$(NetFrameworkMinimum)' != ''"> |
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #112379 to release/9.0-staging
Fixes #111892
/cc @ericstj
In 8.0 we don't need to actually ship this, since we haven't shipped a patch in 8.0 there is nothing to fix. We just want to proactively port this fix so that it's ready should we need to patch in the future.
Customer Impact
.NETFramework project using the latest System.Resources.Extensions package fails to load resources with
FileLoadException.Regression
9.0.1 - this is the first time we've serviced this package. The package didn't account for the serviced assembly version correctly.
Testing
Build / package / inspect redirects. Manually test consuming package in .NETFramework project.
Automated tests here are difficult with current infrastructure as we don't consume the built packages, nor rely on auto-generated bindingRedirects in the same way a customer project does.
Risk
Low - updating target in a single project that only impacts that library's generation of a targets file. If it builds its good.