JIT: Support FIELD_LIST for returns
#112308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add support for returned `FIELD_LIST` nodes in the backend. Until lowering these are supported with arbitrary fields; unlike call arguments the fields are not required to map cleanly to registers. After lowering the fields must map cleanly to the return registers. Lowering is responsible for ensuring this property. * Teach physical promotion to produce `FIELD_LIST` nodes for returned promoted struct locals. Currently lowering ensures the property simply by spilling when the fields do not already map cleanly to registers. In the future it can be taught more efficient ways to recombine the fields to the returned registers. Another step towards supporting the same cases as old promotion with physical promotion.
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
|
/azp run runtime-coreclr jitstress, runtime-coreclr libraries-jitstress, runtime-jit-experimental |
|
Azure Pipelines successfully started running 3 pipeline(s). |
This was referenced Feb 9, 2025
Open
3 tasks
|
/azp run runtime-coreclr jitstress, runtime-coreclr libraries-jitstress, runtime-jit-experimental |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run runtime-jit-experimental |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This reverts commit 15f10e6.
|
cc @dotnet/jit-contrib PTAL @kunalspathak I'll take a closer look at the test failure, but I think it's unlikely to be related as this has almost no diffs on win-x64 and it was green yesterday. In the meantime I think it's ready to be reviewed. Diffs, diffs without old promotion. In the future I expect to enhance lowering's support so that registers can be reconstructed from multiple fields via bitwise instructions. That would e.g. allow a struct like |
|
ping @kunalspathak |
grendello
added a commit
to grendello/runtime
that referenced
this pull request
Feb 19, 2025
* main: (27 commits) Fold null checks against known non-null values (dotnet#109164) JIT: Always track the context for late devirt (dotnet#112396) JIT: array allocation fixes (dotnet#112676) [H/3] Fix test closing connection too fast (dotnet#112691) Fix LINQ handling of iterator.Take(...).Last(...) (dotnet#112680) [browser][MT] move wasm MT CI legs to extra-platforms (dotnet#112690) JIT: Don't use `Compiler::compFloatingPointUsed` to check if FP kills are needed (dotnet#112668) [LoongArch64] Fix a typo within PR#112166. (dotnet#112672) Fix new EH hang on DebugBreak (dotnet#112640) Use encode callback instead of renting a buffer to write to in DSAKeyFormatHelper Move some links to other doc (dotnet#112574) Reflection-based XmlSerializer - Deserialize empty collections and allow for sub-types in collection items. (dotnet#111723) JIT: Use `fgCalledCount` for OSR method entry weight (dotnet#112662) Use Avx10.2 Instructions in Floating Point Conversions (dotnet#111775) Expose StressLog via CDAC and port StressLogAnalyzer to managed code (dotnet#104999) JIT: Use linear block order for MinOpts in LSRA (dotnet#108147) Update dependencies from https://github.com/dotnet/arcade build 20250213.2 (dotnet#112625) JIT: Clean up and optimize call arg lowering (dotnet#112639) Update dependencies from https://github.com/dotnet/emsdk build 20250217.1 (dotnet#112645) JIT: Support `FIELD_LIST` for returns (dotnet#112308) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIELD_LISTnodes in the backend. Until lowering these are supported with arbitrary fields; unlike call arguments the fields are not required to map cleanly to registers. After lowering the fields must map cleanly to the return registers. Lowering is responsible for ensuring this property.FIELD_LISTnodes for returned promoted struct locals.Currently lowering ensures the property simply by spilling when the fields do not already map cleanly to registers. In the future it can be taught more efficient ways to recombine the fields to the returned registers.
Another step towards supporting the same cases as old promotion with physical promotion.