Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update the location of assert for REG_ZR check #112294

Merged
merged 2 commits into from
Feb 8, 2025
Merged

update the location of assert for REG_ZR check #112294

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d202b34
update the location of assert for REG_ZR check
kunalspathak Feb 7, 2025
393ed41
encodeZRtoSP() in caller
kunalspathak Feb 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/coreclr/jit/emitarm64.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5860,11 +5860,11 @@ void emitter::emitIns_R_R_I(instruction ins,
else
{
assert(isGeneralRegisterOrSP(reg1));
assert(isGeneralRegisterOrSP(reg2));

// Is it just a mov?
if (imm == 0)
{
assert(isGeneralRegisterOrSP(reg2));
emitIns_Mov(INS_mov, attr, reg1, reg2, /* canSkip */ true);
return;
}
Expand All @@ -5875,6 +5875,9 @@ void emitter::emitIns_R_R_I(instruction ins,
return;
}

// reg2 can be alread encoded to zero
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// reg2 can be alread encoded to zero
// reg2 can be already encoded to zero

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok to fix in next batch? don't want to run CI again.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

assert(isGeneralRegisterOrSP(reg2) || (reg2 == REG_ZR));

reg1 = encodingSPtoZR(reg1);
reg2 = encodingSPtoZR(reg2);
}
Expand Down
Loading