JIT: Fix illegal instruction encoding for float->float casts #112217
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #112163
This resolves the illegal instruction encoding by no longer pretending that
movss
andmovsd
are 'conversion' instructions, which have different encoding forms.There's a minor codegen improvement (diffs) when a no-op cast has different source and target registers, where we now emit
movaps
instead ofmovss
/movsd
. Previously we would elide the cast only if source and target reg were the same.