Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[android] Update internal documentation on CoreCLR on Android experimental support #112034
[android] Update internal documentation on CoreCLR on Android experimental support #112034
Changes from 6 commits
bbc5a91
f39b8af
22082d1
cbdff5c
a5b8ea9
f287515
c00d2db
be38b6c
d6c70e3
d527a8d
929e49a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you really need to symlink or would it be enough to set xharness ADB_EXE_PATH to
/mnt/<path-to-adb-on-host>
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@elinor-fung ^
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to symlink it somewhere. It didn't necessarily need to be the path from the Android SDK in WSL2, but I found that convenient for just using
adb
from the command line in WSL.When I directly set
ADB_EXE_PATH=/mnt/<path-to-adb-on-host>
, running with xharness would fail with:I admittedly didn't really spend time looking into why.
Directly running
/mnt/<path-to-adb-on-host> install <path-to-apk-in-wsl>
from my WSL terminal works fine, so I guess it may be something with how it gets launched with xharness?