-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve docs on building ILVerify #111851
Merged
Merged
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
95ebc62
Improve docs on building ILVerify
kant2002 df36def
Update src/coreclr/tools/ILVerify/README.md
kant2002 c22db9a
Update src/coreclr/tools/ILVerify/README.md
kant2002 2ae9179
Apply PR suggestions
kant2002 005a7eb
Update src/coreclr/tools/ILVerify/README.md
jkotas 9375635
Update src/coreclr/tools/ILVerify/README.md
jkotas 9a0cd75
Update src/coreclr/tools/ILVerify/README.md
jkotas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -48,24 +48,39 @@ The test project itself is under [src/tests/ilverify](../../../tests/ilverify) | |
|
||
General instructions to build this library can be found [here](https://github.com/dotnet/runtime/blob/main/docs/workflow/testing/coreclr/testing.md). | ||
|
||
As quick snippet which should be enough to build CoreCLR | ||
``` | ||
./build.cmd -s clr.native+clr.corelib+clr.tools+clr.nativecorelib+libs -c release | ||
``` | ||
|
||
As the test project is marked with priority=1, simply building the test projects from the root of the project is not enough. For the initial build of priority=1 in release mode, run the following: | ||
jkotas marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
```sh | ||
src/tests/build.(cmd/sh) release -priority=1 | ||
``` | ||
|
||
or significantly faster use only | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The existing instructions can be deleted. I guess they were written before the test build had |
||
``` | ||
src/tests/build.cmd release tree ilverify | ||
``` | ||
|
||
It is important to not attempt to build the test project using `dotnet build` or `dotnet test`, as this will invalidate the state of the build and requires a full rebuild of both (see this [issue](https://github.com/dotnet/runtime/issues/43967)). | ||
|
||
To incrementally build the ILVerify tests in isolation, run the following: | ||
|
||
```sh | ||
dotnet.(cmd/sh) msbuild ./src/tests/ilverify/ILVerification.Tests.csproj /p:Configuration=Release | ||
dotnet.(cmd/sh) msbuild ./src/tests/ilverify/ILVerificationTests.csproj /p:Configuration=Release | ||
``` | ||
|
||
In order to run the tests, execute: | ||
|
||
on Linux | ||
```sh | ||
artifacts/tests/coreclr/(windows/linux).x64.Release/ilverify/ILVerification.Tests.(cmd/sh) -coreroot=artifacts/tests/coreclr/(windows/linux).x64.Release/Tests/Core_Root | ||
artifacts/tests/coreclr/(windows/linux).x64.Release/ilverify/ILVerificationTests.sh -coreroot=<repo_root>artifacts/tests/coreclr/(windows/linux).x64.Release/Tests/Core_Root | ||
kant2002 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
``` | ||
on Windows | ||
```shell | ||
artifacts\tests\coreclr/\(windows/linux).x64.Release/ilverify/ILVerificationTests.cmd -coreroot=<repo_root>artifacts\tests\coreclr\(windows/linux).x64.Release\Tests\Core_Root | ||
kant2002 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
``` | ||
|
||
|
||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this significantly better than just
-s clr+libs
?