JIT: Transform single-reg args to FIELD_LIST in physical promotion #111590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extend the support for struct arguments in physical promotion to support transforming single-reg structs into a single-field FIELD_LIST node. This allows physically promoted struct arguments passed in a single register to stay in registers. Morph strips the FIELD_LIST in this particular case to match its standard (type-mismatched) representation for single-reg structs. We could produce this IR directly in physical promotion too, but that hits asserts due to type mismatches. Long term we might consider switching to uniformly use FIELD_LIST for structs to avoid the type mismatches we see today.
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
jakobbotsch
commented
Jan 19, 2025
| @@ -2175,7 +2171,7 @@ bool ReplaceVisitor::ReplaceCallArgWithFieldList(GenTreeCall* call, GenTreeLclVa | |||
| { | |||
| Replacement* rep = nullptr; | |||
| if (agg->OverlappingReplacements(argNode->GetLclOffs() + seg.Offset, seg.Size, &rep, nullptr) && | |||
| rep->NeedsWriteBack) | |||
| !rep->NeedsReadBack) | |||
There was a problem hiding this comment.
The previous check was conservative. It is possible for both NeedsWriteBack and NeedsReadBack to be false, in which case both the struct base local and replacement local are up to date; in that case we should prefer the value from the replacement local. This is the right check for that.
|
/azp run runtime-coreclr jitstress, runtime-coreclr libraries-jitstress, runtime-jit-experimental |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
Failures look like #111777 and #111625. cc @dotnet/jit-contrib PTAL @EgorBo Diffs, diffs with old promotion disabled. Another step towards making physical promotion able to handle all the same cases as old promotion. |
EgorBo
approved these changes
Feb 1, 2025
grendello
added a commit
to grendello/runtime
that referenced
this pull request
Feb 3, 2025
* main: System.Net.Http.WinHttpHandler.StartRequestAsync assertion failed (dotnet#109799) Keep test PDB in helix payload for native AOT (dotnet#111949) Build the RID-specific System.IO.Ports packages in the VMR (dotnet#112054) Always inline number conversions (dotnet#112061) Use Contains{Any} in Regex source generator (dotnet#112065) Update dependencies from https://github.com/dotnet/arcade build 20250130.5 (dotnet#112013) JIT: Transform single-reg args to FIELD_LIST in physical promotion (dotnet#111590) Ensure that math calls into the CRT are tracked as needing vzeroupper (dotnet#112011) Use double.ConvertToIntegerNative where safe to do in System.Random (dotnet#112046) JIT: Compute `fgCalledCount` after synthesis (dotnet#112041) Simplify boolean logic in `TimeZoneInfo` (dotnet#112062) JIT: Update type when return temp is freshly created (dotnet#111948) Remove unused build controls and simplify DotNetBuild.props (dotnet#111986) Fix case-insensitive JSON deserialization of enum member names (dotnet#112028) WasmAppBuilder: Remove double computation of a value (dotnet#112047) Disable LTCG for brotli and zlibng. (dotnet#111805) JIT: Improve x86 unsigned to floating cast codegen (dotnet#111595) simplify x86 special intrinsic imports (dotnet#111836) JIT: Try to retain entry weight during profile synthesis (dotnet#111971) Fix explicit offset of ByRefLike fields. (dotnet#111584)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend the support for struct arguments in physical promotion to support transforming single-reg structs into a single-field FIELD_LIST node. This allows physically promoted struct arguments passed in a single register to stay in registers.
Morph strips the FIELD_LIST in this particular case to match its standard (type-mismatched) representation for single-reg structs. We could produce this IR directly in physical promotion too, but that hits asserts due to type mismatches. Long term we might consider switching to uniformly use FIELD_LIST for structs to avoid the type mismatches we see today.
This extends #104370 to handle the remaining cases.