Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JIT: Model GT_RETURN kills with contained operand #111230

Merged
merged 1 commit into from
Jan 12, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/coreclr/jit/lsrabuild.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -4300,6 +4300,16 @@ int LinearScan::BuildReturn(GenTree* tree)
return 1;
}
}
else
{
// In other cases we require the incoming operand to be in the
// right register(s) when we build the use(s), and thus we do not
// need to model that as a kill. However, in this case we have a
// contained operand. Codegen will move it to the right return
// registers; thus they will be killed.
regMaskTP killedRegs = compiler->compRetTypeDesc.GetABIReturnRegs(compiler->info.compCallConv);
buildKillPositionsForNode(tree, currentLoc + 1, killedRegs);
}

// No kills or defs.
return 0;
Expand Down
Loading