-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/8.0-staging] Update .NET 8 build images to use Azure Linux #110199
Conversation
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
This is infra, so I marked it as @sbomer @akoeplinger friendly reminder that today's Code Complete day for the February 2025 Release. If you want this fix included in that release, please make sure this PR is merged before 4pm PT. Otherwise it will have to wait until next month. |
It seems the nodejs installation inside emsdk is broken, possibly related to dotnet/dotnet-buildtools-prereqs-docker#1291:
It seems the npm install uses the |
The latest npm doesn't support node 15.x anymore, install npm 9.x instead. Should unblock dotnet/runtime#110199 (comment)
Where is this Node 15 version coming from? That's been EOL for more than 3 years. We shouldn't be making changes to accommodate for that version. Rather we should be updating Node to a supported version. |
@mthalman as I explained in dotnet/dotnet-buildtools-prereqs-docker#1291 (comment) the emsdk version that we're shipping is frozen in time for 8.0. Upgrading to a newer node and monkey-patching it into the emsdk installed in the docker image is just a hack to get rid of the packages that are picked up by the scanners. I didn't want to bump too far ahead of the node that emsdk ships with but looks like we need to bump to at least 16.0 |
Still trying to unblock dotnet/runtime#110199
00e6085
into
dotnet:release/8.0-staging
Replaces the build images for which we have equivalent Azure Linux images (see dotnet/dotnet-buildtools-prereqs-docker#1173).
Fixes #112191