Update System.Speech to also recognize Speech_OneCore #110123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danmoseley
reviewed
Nov 25, 2024
| @@ -21,7 +21,12 @@ protected ObjectTokenCategory(string keyId, RegistryDataKey key) | |||
| internal static ObjectTokenCategory Create(string sCategoryId) | |||
| { | |||
| RegistryDataKey key = RegistryDataKey.Open(sCategoryId, true); | |||
There was a problem hiding this comment.
I assume this doesn't throw if the key isn't there -- it ends up calling into the COM interface so I guess that's the case
danmoseley
approved these changes
Nov 25, 2024
If we were still adding features there, sure. |
|
Without context, I don't know whether it's adding features, or simply ensuring the scenario continues to work fully. Anyway, separate to this. |
|
does this fix #108991 |
Possibly. It depends which voices they mean. This won't help with the "natural voices". |
This was referenced Dec 5, 2024
|
@stephentoub ok to merge? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #110120
@danmoseley, I believe you ported System.Speech over to core. Are you aware of reasons to not do this? Is there someone we should ask?