Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable some chrome-DebuggerTests that are crashing with DeadLetter #109871

Closed
wants to merge 3 commits into from
Closed

Disable some chrome-DebuggerTests that are crashing with DeadLetter #109871

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c4766de
Disable some chrome-DebuggerTests that are crashing with DeadLetter
tannergooding Nov 15, 2024
31d183d
Update CallFunctionOnTests.cs
tannergooding Nov 15, 2024
5f74226
Update MiscTests.cs
tannergooding Nov 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/mono/browser/debugger/DebuggerTestSuite/BreakpointTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

namespace DebuggerTests
{

[ActiveIssue("https://github.com/dotnet/runtime/issues/109870")]
public class BreakpointTests : DebuggerTests
{
public BreakpointTests(ITestOutputHelper testOutput) : base(testOutput)
Expand Down
2 changes: 1 addition & 1 deletion src/mono/browser/debugger/DebuggerTestSuite/CallFunctionOnTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@

namespace DebuggerTests
{

[ActiveIssue("https://github.com/dotnet/runtime/issues/109870")]
public class CallFunctionOnTests : DebuggerTests
{
public CallFunctionOnTests(ITestOutputHelper testOutput) : base(testOutput)
Expand Down
4 changes: 0 additions & 4 deletions src/mono/browser/debugger/DebuggerTestSuite/DebuggerTestSuite.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,6 @@

<Compile Include="..\BrowserDebugProxy\Common\*.cs" />

<!-- TODO [ActiveIssue("https://github.com/dotnet/runtime/issues/85168")]
<Compile Remove="EvaluateOnCallFrameTests.cs" />
-->

<Compile Include="$(LibrariesProjectRoot)Microsoft.Extensions.Logging\tests\DI.Common\Common\src\XunitLoggerFactoryExtensions.cs" />
<Compile Include="$(LibrariesProjectRoot)Microsoft.Extensions.Logging\tests\DI.Common\Common\src\XunitLoggerProvider.cs" />
</ItemGroup>
Expand Down
13 changes: 7 additions & 6 deletions src/mono/browser/debugger/DebuggerTestSuite/EvaluateOnCallFrame2Tests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
namespace DebuggerTests
{
// TODO: static async, static method args
[ActiveIssue("https://github.com/dotnet/runtime/issues/109870")]
public class EvaluateOnCallFrame2Tests : DebuggerTests
{
public EvaluateOnCallFrame2Tests(ITestOutputHelper testOutput) : base(testOutput)
Expand Down Expand Up @@ -713,7 +714,7 @@ await EvaluateOnCallFrameAndCheck(id,
("instance.str[3]", TChar('c'))
);
});

[Fact]
public async Task EvaluateStaticGetterInValueType() => await CheckInspectLocalsAtBreakpointSite(
$"DebuggerTests.TypeProperties", "Run", 3, "DebuggerTests.TypeProperties.Run",
Expand Down Expand Up @@ -776,7 +777,7 @@ await EvaluateOnCallFrameAndCheck(id,
("c[cc.numArray[j], cc.numArray[0]]", TNumber("3")), //multiple ElementAccessExpressionSyntaxes
("c[cc.numArray[cc.numList[0]], cc.numArray[i]]", TNumber("3")),
("c[cc.numArray[cc.numList[0]], cc.numArray[cc.numArray[i]]]", TNumber("4"))
);
);
});

[Fact]
Expand All @@ -795,10 +796,10 @@ await EvaluateOnCallFrameAndCheck(id,
("s[cc.numArray[j], cc.numArray[0]]", TNumber("3")), //multiple ElementAccessExpressionSyntaxes
("s[cc.numArray[cc.numList[0]], cc.numArray[i]]", TNumber("3")),
("s[cc.numArray[cc.numList[0]], cc.numArray[cc.numArray[i]]]", TNumber("4"))
);
);
});


[Fact]
public async Task EvaluateMethodsWithObjectParams() => await CheckInspectLocalsAtBreakpointSite(
"DebuggerTests.FastCheck", "run", 6, "DebuggerTests.FastCheck.run",
Expand All @@ -814,7 +815,7 @@ await EvaluateOnCallFrameAndCheck(id,
("mc.Method(EvaluateStaticFieldsInInstanceClass.StaticField)", TNumber(70)),
("mc.Method(instance.StaticField)", TNumber(70)),
("mc.Method(instance2.propInt)", TNumber(12))
);
);
});

// https://github.com/dotnet/runtime/issues/98086
Expand All @@ -841,7 +842,7 @@ public async Task EvaluateValueTypeWithObjectValueType() => await CheckInspectLo
await RuntimeEvaluateAndCheck(
("myVar.MyMethod()", TNumber(10)));
});

// https://github.com/dotnet/runtime/issues/106311
[ConditionalFact(nameof(RunningOnChrome))]
public async Task EvaluateOnValueTypeWithoutExtraSpace() => await CheckInspectLocalsAtBreakpointSite(
Expand Down
5 changes: 3 additions & 2 deletions src/mono/browser/debugger/DebuggerTestSuite/EvaluateOnCallFrameTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
namespace DebuggerTests
{
// TODO: static async, static method args
[ActiveIssue("https://github.com/dotnet/runtime/issues/109870")]
public class EvaluateOnCallFrameTests : DebuggerTests
{
public EvaluateOnCallFrameTests(ITestOutputHelper testOutput) : base(testOutput)
Expand Down Expand Up @@ -648,9 +649,9 @@ await EvaluateOnCallFrameAndCheck(id,
("cc.indexedByBool[false]", TString("FALSE"))
);
var (_, res) = await EvaluateOnCallFrame(id,"cc.indexedByStr[\"invalid\"]", expect_ok: false);
Assert.True(res.Error["result"]?["description"]?.Value<string>().StartsWith("Cannot evaluate '(cc.indexedByStr[\"invalid\"]", StringComparison.Ordinal));
Assert.True(res.Error["result"]?["description"]?.Value<string>().StartsWith("Cannot evaluate '(cc.indexedByStr[\"invalid\"]", StringComparison.Ordinal));
(_, res) = await EvaluateOnCallFrame(id,"cc.indexedByStr[null]", expect_ok: false);
Assert.True(res.Error["result"]?["description"]?.Value<string>().StartsWith("Cannot evaluate '(cc.indexedByStr[null]", StringComparison.Ordinal));
Assert.True(res.Error["result"]?["description"]?.Value<string>().StartsWith("Cannot evaluate '(cc.indexedByStr[null]", StringComparison.Ordinal));
});

[Fact]
Expand Down
2 changes: 1 addition & 1 deletion src/mono/browser/debugger/DebuggerTestSuite/MiscTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

namespace DebuggerTests
{

[ActiveIssue("https://github.com/dotnet/runtime/issues/109870")]
public class MiscTests : DebuggerTests
{
public MiscTests(ITestOutputHelper testOutput) : base(testOutput)
Expand Down
Loading