Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable GS cookie checks for LightUnwind #109524

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Conversation

jkotas
Copy link
Member

@jkotas jkotas commented Nov 4, 2024

LightUnwind does not track sufficient context to compute GS cookie address

Fixes #109242

@jkotas
Copy link
Member Author

jkotas commented Nov 4, 2024

/azp run runtime-coreclr outerloop

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

LightUnwind does not track sufficient context to compute GS cookie address

Fixes dotnet#109242
@jkotas
Copy link
Member Author

jkotas commented Nov 4, 2024

/azp run runtime-coreclr outerloop

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@janvorli janvorli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@jkotas
Copy link
Member Author

jkotas commented Nov 5, 2024

/ba-g macOS-12 environment is deprecated

@jkotas jkotas merged commit da78cf7 into dotnet:main Nov 5, 2024
122 of 145 checks passed
@jkotas jkotas deleted the issue-109242 branch November 5, 2024 00:58
@jkotas
Copy link
Member Author

jkotas commented Nov 5, 2024

/backport to release/9.0-staging

Copy link
Contributor

github-actions bot commented Nov 5, 2024

Started backporting to release/9.0-staging: https://github.com/dotnet/runtime/actions/runs/11675541464

@dotnet dotnet deleted a comment from github-actions bot Nov 5, 2024
@dotnet dotnet deleted a comment from github-actions bot Nov 5, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assembly::Load crashes C++/CLI app in try block with 9.0.0-rc.2.24473.5
2 participants