Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing analyzer warning for generics in containing type #109392

Merged
merged 2 commits into from
Nov 1, 2024
Merged

Fix missing analyzer warning for generics in containing type #109392

merged 2 commits into from
Nov 1, 2024

Conversation

sbomer
Copy link
Member

@sbomer sbomer commented Oct 30, 2024 •
edited
Loading

Fixes the IL2091 warnings missed by the analyzer in #109270.

Fixes #109270

@sbomer sbomer requested a review from a team October 30, 2024 22:01
@sbomer sbomer requested a review from marek-safar as a code owner October 30, 2024 22:01
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-Tools-ILLink .NET linker development as well as trimming analyzers label Oct 30, 2024
@dotnet-policy-service dotnet-policy-service bot added the linkable-framework Issues associated with delivering a linker friendly framework label Oct 30, 2024
This was referenced Oct 31, 2024
Open
Open
@sbomer
PR feedback
7d30d0b 
- Add tests for property/event
- Fix behavior for type arguments and base types
jtschuster
jtschuster approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@jtschuster jtschuster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@build-analysis build-analysis bot mentioned this pull request Nov 1, 2024
Open
3 tasks
@sbomer
Copy link
Member Author

sbomer commented Nov 1, 2024 •
edited
Loading

/ba-g "chrome-DebuggerTests dead-lettered", potentially #108078

@sbomer sbomer merged commit ed77814 into dotnet:main Nov 1, 2024
72 of 76 checks passed
sbomer added a commit that referenced this pull request Nov 4, 2024
@sbomer
Revert "Fix missing analyzer warning for generics in containing type (#…
ae34f9c 
…109392)"

This reverts commit ed77814.
This was referenced Nov 4, 2024
Merged
Merged
sbomer added a commit that referenced this pull request Nov 4, 2024
@sbomer
Revert "Fix missing analyzer warning for generics in containing type (#…
10af5e0 
…109392)" (#109520)

This reverts commit ed77814.

Fixes a timeout in CLR_Tools_Tests.
sbomer added a commit to sbomer/runtime that referenced this pull request Nov 4, 2024
@sbomer
Reapply "Fix missing analyzer warning for generics in containing type (…
3b24432 
…dotnet#109392)" (dotnet#109520)

This reverts commit 10af5e0.
@github-actions github-actions bot locked and limited conversation to collaborators Dec 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jtschuster jtschuster jtschuster approved these changes

@marek-safar marek-safar Awaiting requested review from marek-safar marek-safar is a code owner

Assignees

@sbomer sbomer

Labels
area-Tools-ILLink .NET linker development as well as trimming analyzers linkable-framework Issues associated with delivering a linker friendly framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Several IL20XX trim warnings missed by analyzers, only show up with ILC
2 participants
@sbomer @jtschuster