Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/9.0] Use floating tag for webassembly image #109374

Merged
merged 1 commit into from
Dec 17, 2024
Merged

[release/9.0] Use floating tag for webassembly image #109374

merged 1 commit into from
Dec 17, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Oct 30, 2024 •
edited by akoeplinger
Loading

Backport of #109240 to release/9.0

/cc @mthalman

Customer Impact

  • Customer reported
  • Found internally

Updates the reference container image tag to be the floating tag, which will be kept current for all updates. The previously used tag is pinned to a specific version which is considered EOL at this point.

Regression

  • Yes
  • No

Testing

CI testing

Risk

Low

@mthalman mthalman requested a review from a team October 30, 2024 16:08
ViktorHofer
ViktorHofer approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@ViktorHofer ViktorHofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this is just tell-mode, right?

@mthalman
Copy link
Member

Oh, should I be targeting release/9.0-staging instead?

@ViktorHofer
Copy link
Member

Yes. release/9.0 is already locked down.

@mthalman mthalman changed the base branch from release/9.0 to release/9.0-staging October 30, 2024 17:31
This was referenced Oct 30, 2024
Open
Closed
Closed
@ericstj ericstj requested a review from lewing December 17, 2024 17:34
@ericstj
Copy link
Member

ericstj commented Dec 17, 2024

@mthalman - looks like this PR might need some work.

@ericstj ericstj added the needs-author-action An issue or pull request that requires more info or actions from the author. label Dec 17, 2024
@akoeplinger akoeplinger force-pushed the backport/pr-109240-to-release/9.0 branch from 749497b to caed8fe Compare December 17, 2024 18:14
@dotnet-policy-service dotnet-policy-service bot removed the needs-author-action An issue or pull request that requires more info or actions from the author. label Dec 17, 2024
@akoeplinger
Copy link
Member

this happens when you use GitHub's UI to switch branches. I've force-pushed the commit.

@akoeplinger akoeplinger added the Servicing-approved Approved for servicing release label Dec 17, 2024
@akoeplinger
Copy link
Member

this is a testing-only change, tell-mode

@akoeplinger akoeplinger merged commit 7f7a8b6 into release/9.0-staging Dec 17, 2024
82 of 84 checks passed
@akoeplinger akoeplinger deleted the backport/pr-109240-to-release/9.0 branch December 17, 2024 21:57
@github-actions github-actions bot locked and limited conversation to collaborators Jan 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@akoeplinger akoeplinger akoeplinger approved these changes

@ViktorHofer ViktorHofer ViktorHofer approved these changes

@lewing lewing Awaiting requested review from lewing

Assignees

@mthalman mthalman

Labels
arch-wasm WebAssembly architecture area-Infrastructure Servicing-approved Approved for servicing release
Projects
Runtime Infra
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mthalman @ViktorHofer @ericstj @akoeplinger