Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dispose async test timeout and better diagnostics #106272

Merged
merged 1 commit into from
Aug 12, 2024
Merged

Update dispose async test timeout and better diagnostics #106272

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .../Microsoft.Extensions.DependencyInjection/tests/DI.Tests/ServiceProviderContainerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,10 +392,10 @@ public void GetAsyncService_DisposeAsyncOnSameThread_ThrowsAndDoesNotHangAndDisp
var service = sp.GetRequiredService<DisposeServiceProviderInCtorAsyncDisposable>();
});
});
}).Wait(TimeSpan.FromSeconds(10));
}).Wait(TimeSpan.FromSeconds(20));
Copy link
Member Author

@steveharter steveharter Aug 12, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To help determine if the test is timing out; likely this will be reverted.


Assert.True(doesNotHang);
Assert.True(asyncDisposableResource.DisposeAsyncCalled);
Assert.True(doesNotHang, "!doesNotHang");
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To verify which Assert.True is actually failing.

Assert.True(asyncDisposableResource.DisposeAsyncCalled, "!DisposeAsyncCalled");
}

[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupported))]
Expand Down
Loading