Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop creating map of assembly refs to name for Module #106210

Merged
merged 1 commit into from
Aug 10, 2024
Merged

Stop creating map of assembly refs to name for Module #106210

merged 1 commit into from
Aug 10, 2024

Conversation

elinor-fung
Copy link
Member

@elinor-fung elinor-fung commented Aug 9, 2024 •
edited
Loading

Looks like more NGEN remnants - not called/used at all in current code base.

cc @jkotas @AaronRobinsonMSFT

@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

AaronRobinsonMSFT
AaronRobinsonMSFT approved these changes Aug 9, 2024
View reviewed changes
Copy link
Member

@AaronRobinsonMSFT AaronRobinsonMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with the history of this, but I don't see any callers, so LGTM.

This was referenced Aug 10, 2024
Open
Open
Closed
@elinor-fung elinor-fung merged commit da38f78 into dotnet:main Aug 10, 2024
87 of 90 checks passed
@elinor-fung elinor-fung deleted the remove-assemblyRefByNameTable branch August 10, 2024 00:59
@github-actions github-actions bot locked and limited conversation to collaborators Sep 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jkotas jkotas jkotas approved these changes

@AaronRobinsonMSFT AaronRobinsonMSFT AaronRobinsonMSFT approved these changes

Assignees

@elinor-fung elinor-fung

Labels
area-VM-coreclr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elinor-fung @jkotas @AaronRobinsonMSFT