Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix _LOGALLOC define #106023

Merged
merged 1 commit into from
Aug 6, 2024
Merged

Fix _LOGALLOC define #106023

merged 1 commit into from
Aug 6, 2024

Conversation

t-mustafin
Copy link
Contributor

@t-mustafin t-mustafin commented Aug 6, 2024 •
edited
Loading

_LOGALLOC define was in gc.h while all usages in vm and this vm files do not include gc.h:

grep  src/coreclr/ -re LOGALLOC
src/coreclr/vm/gchelpers.cpp:#ifdef  _LOGALLOC
src/coreclr/vm/gchelpers.cpp:#ifdef  _LOGALLOC
src/coreclr/vm/gchelpers.cpp:#endif // _LOGALLOC
src/coreclr/vm/jitinterface.cpp:#ifdef _LOGALLOC
src/coreclr/vm/jitinterface.cpp:#endif // _LOGALLOC
src/coreclr/gc/gc.h:#define  _LOGALLOC

It caused lack of object allocation messages in common clr log.

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Aug 6, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/gc
See info in area-owners.md if you want to be subscribed.

@t-mustafin
Copy link
Contributor Author

cc @dotnet/samsung

mangod9
mangod9 reviewed Aug 6, 2024
View reviewed changes
src/coreclr/vm/object.h Outdated
@@ -86,6 +86,10 @@ class ArgDestination;

struct RCW;

#ifdef _DEBUG
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feels odd in object.h. Can it be added to log.h?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, done. Actually it just duplicates "_DEBUG" macro. Maybe it should be cleaned up and ifdef's should check "_DEBUG" macro instead?

This was referenced Aug 6, 2024
Open
Open
Closed
@jkotas jkotas merged commit 47ebcf3 into dotnet:main Aug 6, 2024
87 of 90 checks passed
gbalykov
gbalykov reviewed Aug 7, 2024
View reviewed changes
Copy link
Member

@gbalykov gbalykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@t-mustafin t-mustafin deleted the fix_logalloc branch August 7, 2024 09:15
@github-actions github-actions bot locked and limited conversation to collaborators Sep 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gbalykov gbalykov gbalykov left review comments

@tomeksowi tomeksowi tomeksowi approved these changes

@mangod9 mangod9 mangod9 approved these changes

Assignees

@t-mustafin t-mustafin

Labels
area-GC-coreclr community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@t-mustafin @tomeksowi @gbalykov @mangod9 @jkotas