[browser] tests and fixes for heap larger than 2GB #104662
Conversation
|
I would close it already (when the CI is ready), the issue was meant to track down the reasons for this behavior. We have a new issue for fixing the reasons (#104790). |
| } | ||
|
|
||
| // marshall string array to JS | ||
| string [] testArray = new [] { "M", "e", "m", "o", "r", "y", "T", "e", "s", "t" }; |
There was a problem hiding this comment.
Please make each string here random (constants are not allocated) and large enough, so that the JS side is forced to make allocations above 2GB mark. And overflow to negative numbers. Maybe run this in a loop.
There was a problem hiding this comment.
Then let's use the arrayHolder that is already prepared.
There was a problem hiding this comment.
2GB string allocation with random data is taking too long, not only to run WBT but to even debug it.
There was a problem hiding this comment.
Also, we cannot just take arrayHolder and send it to JS to force JS to allocate 2GB because interop does not support array of arrays. Allocating flat array of 2GB requires more linear memory and can be problematic from other reasons than investigated in the issue. Allocating an array of strings theoretically should work but as I already mentioned, it takes tens of minutes to finish the allocation, even using StringBuilder.
@maraf, do you have a good idea how to fulfill the requirements?
There was a problem hiding this comment.
Never mind, I realized that the key point was "allocations above 2GB mark", not "allocations of 2GB".
There was a problem hiding this comment.
We're allocating 2 621 440 000 bytes so more than max int. There are no traces of overflow. Let's merge this to take care of the relink fix PR that is built on top of this.
…was not imported yet, please call JSHost.ImportAsync() first. Error: Assert failed: ES6 module 籨Ȍ"
Fixes #104618.
We're adding WBT that uses
EmccMaximumHeapSize.It surfaces an issue: relink is needed to pass
EmccMaximumHeapSizefurther to emscriptenruntime/src/mono/browser/build/BrowserWasmApp.targets
Line 299 in 61f08d3
otherwise we will get OOM failure.
Related issues: #104790