Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clone for IncrementalHash and KMAC #103479

Merged
merged 11 commits into from
Jun 18, 2024
Merged

Clone for IncrementalHash and KMAC #103479

merged 11 commits into from
Jun 18, 2024

Conversation

vcsjones
Copy link
Member

@vcsjones vcsjones commented Jun 14, 2024

Closes #103170

Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

1 similar comment
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones
See info in area-owners.md if you want to be subscribed.

@vcsjones
Copy link
Member Author

/azp run runtime-androidemulator, runtime-wasm, runtime-ioslikesimulator

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@vcsjones vcsjones added this to the 9.0.0 milestone Jun 14, 2024
Copy link
Member

@bartonjs bartonjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of superfluous blank lines. If removing them would put making the preview 6 cutoff (Tuesday afternoon, PT) at risk, merge with them here. If you have the time, I'd prefer them tidied up.

Co-authored-by: Jeremy Barton <jbarton@microsoft.com>
@vcsjones vcsjones added the cryptographic-docs-impact Issues impacting cryptographic docs. Cleared and reused after documentation is updated each release. label Jun 18, 2024
@vcsjones
Copy link
Member Author

Since the only change from the last run was white space changes, I am not going to run the Android / iOS / Browser legs again. And because they did not fail in S.S.Cryptography, merging.

@vcsjones vcsjones merged commit 59f7bbc into dotnet:main Jun 18, 2024
97 checks passed
@vcsjones vcsjones deleted the hash-clone branch June 18, 2024 06:41
@github-actions github-actions bot locked and limited conversation to collaborators Jul 18, 2024
@bartonjs bartonjs added the tracking This issue is tracking the completion of other related issues. label Sep 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Security cryptographic-docs-impact Issues impacting cryptographic docs. Cleared and reused after documentation is updated each release. new-api-needs-documentation tracking This issue is tracking the completion of other related issues.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[API Proposal]: Clone for IncrementalHash and KMAC
2 participants