-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to zlib-ng, part 1: copy source code only #102520
Conversation
Tagging subscribers to this area: @dotnet/area-system-io-compression |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as long as all changes to zlib-ng are captured in zlib-ng-version.txt.
@jkotas I have a question about your comment in the other PR:
For my own education, why would this cause problems? |
Source-build has issues with introducing binary files into the repo. There's a whole process that needs to be done to make sure that they're not introduced into the final product in any way (including having the source-build build itself remove the files from disk before starting). It's easier if we don't have the binaries in the first place. |
* Bring in the zlib-ng source code into the repo but without plugging it in yet. * Include the required zlib-ng license and version changes. * Remove the zlib-ng/doc/ and zlib-ng/tests/ folders and mention this in the newly added zlib-ng-version.txt file.
* Bring in the zlib-ng source code into the repo but without plugging it in yet. * Include the required zlib-ng license and version changes. * Remove the zlib-ng/doc/ and zlib-ng/tests/ folders and mention this in the newly added zlib-ng-version.txt file.
Contributes to #101465
As requested in the original PR, to make reviewing easier, I am submitting this separate PR that copies the zlib-ng source code and updates the licensing files, but without consuming it in runtime yet.