[mono][gc] Remove reliance on regs/stack scanning in some cases #101478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @BrzVlad |
This was referenced Apr 24, 2024
Closed
lambdageek
approved these changes
Apr 24, 2024
This was referenced Apr 24, 2024
Closed
Closed
d1eff88 to
99c156a
Compare
This was referenced Apr 25, 2024
Closed
We were assuming the object is kept alive from the stack/regs, which is not reliable on wasm.
Ruihan-Yin
pushed a commit
to Ruihan-Yin/runtime
that referenced
this pull request
May 30, 2024
…et#101478) * [mono][sgen] Allocated gchandle for this object when invoking finalizers We were assuming the object is kept alive from the stack/regs, which is not reliable on wasm. * [mono][metadata] Allocate handle while operating with newly allocated RuntimeType * Enable test suite
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On wasm we can miss refs, because we can't scan the native regs/stack. Make sure we explicitly use coop/gc handles instead. Hopefully fixes some gc crashes on wasm mt.