-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump minimum Apple OS versions #101342
Bump minimum Apple OS versions #101342
Conversation
As defined in the ".NET 9 - Supported OS versions" document: https://github.com/dotnet/core/blob/main/release-notes/9.0/supported-os.md - macOS 12.0 - iOS/iOSSimulator 12.2 - tvOS/tvOSSimulator 12.2 - MacCatalyst 15.0 (== macOS 12.0) Fixes dotnet#91736
src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/ObjectWriter/MachObjectWriter.cs
Outdated
Show resolved
Hide resolved
…r/MachObjectWriter.cs Co-authored-by: Filip Navara <filip.navara@gmail.com>
Looks like pal_signverify.c will need to silence a couple of deprecation warnings in the DSA code ( runtime/src/native/libs/System.Security.Cryptography.Native.Apple/pal_keychain_macos.c Lines 19 to 22 in a3dc133
There's no replacement for these APIs for this specific security algorithm, so the only other alternative is to drop the support entirely which is out of scope for this PR. |
Thanks, will add the suppression. We're also seeing this in the maccatalyst build:
|
The |
Thanks, pushed the suppression and filed #101349 I also got an error when building locally with Xcode 15 from the new linker about -bind_at_load being deprecated for macOS (looks like it checks the min OS target since we didn't hit this before) so I also added a check to not pass that flag for the new linker. |
There are a number of deprecation suppressions we can tackle with the iOS version bump. I already have a branch to start this, so I can include this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Just a small comment: I noticed that the table in https://github.com/dotnet/core/blob/main/release-notes/9.0/supported-os.md is not in sync with these changes e.g., MacCatalyst version is specified as 12.0+
src/libraries/System.Security.Cryptography/src/System/Security/Cryptography/AesGcm.macOS.cs
Outdated
Show resolved
Hide resolved
Yeah this was accidentally overwritten: dotnet/core#9279 |
As defined in the ".NET 9 - Supported OS versions" document: https://github.com/dotnet/core/blob/main/release-notes/9.0/supported-os.md - macOS 12.0 - iOS/iOSSimulator 12.2 - tvOS/tvOSSimulator 12.2 - MacCatalyst 15.0 (== macOS 12.0) Fixes dotnet#91736
As defined in the ".NET 9 - Supported OS versions" document: https://github.com/dotnet/core/blob/main/release-notes/9.0/supported-os.md - macOS 12.0 - iOS/iOSSimulator 12.2 - tvOS/tvOSSimulator 12.2 - MacCatalyst 15.0 (== macOS 12.0) Fixes dotnet#91736
As defined in the ".NET 9 - Supported OS versions" document: https://github.com/dotnet/core/blob/main/release-notes/9.0/supported-os.md
Fixes #91736