[mono] Generic Default Interface Method crash with Environment.StackTrace

[bholmes]

Description

Calling Environment.StackTrace from a default interface method of a generic interface causes a crash in the Mono runtime.

Reproduction Steps

Compile and run the following program with the Mono runtime...

using System;

namespace DefItf
{
    public interface IPublisher<out TData>
    {
        event Action<TData> OnPublish;
    }

    public interface ISubscriber<T>
    {
        void OnReceiveSubscription(T data);

        void Subscribe(IPublisher<T> publisher)
        {
            InternalSubscribe(this, publisher);
        }

        void Unsubscribe(IPublisher<T> publisher)
        {
            InternalUnsubscribe(this, publisher);
        }

        protected static void InternalSubscribe(ISubscriber<T> subscriber, IPublisher<T> publisher)
        {
            publisher.OnPublish += subscriber.OnReceiveSubscription;
            Console.WriteLine(Environment.StackTrace.ToString());
        }

        protected static void InternalUnsubscribe(ISubscriber<T> subscriber, IPublisher<T> publisher)
        {
            publisher.OnPublish -= subscriber.OnReceiveSubscription;
            Console.WriteLine(Environment.StackTrace.ToString());
        }
    }

    public class PubTest :IPublisher<InputData>
    {
        public event Action<InputData> OnPublish;

        public void Call() => OnPublish?.Invoke(new InputData());
    }

    public class InputData
    {
        public int i;
    }

    public class Program : ISubscriber<InputData>
    {
        static void Main(string[] args)
        {
            new Program().Start();
        }
        
        // Start is called before the first frame update
        public void Start()
        {
            var pub = new PubTest();
            var sub = (ISubscriber<InputData>)this;
            sub.Subscribe(pub);
            pub.Call();
            sub.Unsubscribe(pub);
        }

        public void Subscribe(IPublisher<InputData> publisher)
        {
            ISubscriber<InputData>.InternalSubscribe(this, publisher);
        }

        public void OnReceiveSubscription(InputData data)
        {
            Console.WriteLine($"do something");
        }
    }
}

Expected behavior

Program completes without crashing and the output is written to the screen.

Actual behavior

Program crashes.

Regression?

Not a regression

Known Workarounds

No known workarounds.

Configuration

• Tested with Mono runtime build from code, main branch 56d807d.
• Verified on Windows and Linux x64

Other information

No response

[dotnet-issue-labeler]

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

[danmoseley]

Is it possible to share a stack trace?

[ghost]

Tagging subscribers to this area:
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Description

Calling Environment.StackTrace from a default interface method of a generic interface causes a crash in the Mono runtime.

Reproduction Steps

Compile and run the following program with the Mono runtime...

using System;

namespace DefItf
{
    public interface IPublisher<out TData>
    {
        event Action<TData> OnPublish;
    }

    public interface ISubscriber<T>
    {
        void OnReceiveSubscription(T data);

        void Subscribe(IPublisher<T> publisher)
        {
            InternalSubscribe(this, publisher);
        }

        void Unsubscribe(IPublisher<T> publisher)
        {
            InternalUnsubscribe(this, publisher);
        }

        protected static void InternalSubscribe(ISubscriber<T> subscriber, IPublisher<T> publisher)
        {
            publisher.OnPublish += subscriber.OnReceiveSubscription;
            Console.WriteLine(Environment.StackTrace.ToString());
        }

        protected static void InternalUnsubscribe(ISubscriber<T> subscriber, IPublisher<T> publisher)
        {
            publisher.OnPublish -= subscriber.OnReceiveSubscription;
            Console.WriteLine(Environment.StackTrace.ToString());
        }
    }

    public class PubTest :IPublisher<InputData>
    {
        public event Action<InputData> OnPublish;

        public void Call() => OnPublish?.Invoke(new InputData());
    }

    public class InputData
    {
        public int i;
    }

    public class Program : ISubscriber<InputData>
    {
        static void Main(string[] args)
        {
            new Program().Start();
        }
        
        // Start is called before the first frame update
        public void Start()
        {
            var pub = new PubTest();
            var sub = (ISubscriber<InputData>)this;
            sub.Subscribe(pub);
            pub.Call();
            sub.Unsubscribe(pub);
        }

        public void Subscribe(IPublisher<InputData> publisher)
        {
            ISubscriber<InputData>.InternalSubscribe(this, publisher);
        }

        public void OnReceiveSubscription(InputData data)
        {
            Console.WriteLine($"do something");
        }
    }
}

Expected behavior

Program completes without crashing and the output is written to the screen.

Actual behavior

Program crashes.

Regression?

Not a regression

Known Workarounds

No known workarounds.

Configuration

• Tested with Mono runtime build from code, main branch 56d807d.
• Verified on Windows and Linux x64

Other information

No response

Author:	bholmes
Assignees:	-
Labels:	untriaged, area-VM-meta-mono
Milestone:	-

[bholmes]

Thread 1 "HelloWorld" received signal SIGSEGV, Segmentation fault.
0x00007ffff739912c in m_class_get_class_kind (klass=0x100000002c8) at /home/bill/dev/runtime/src/mono/mono/metadata/class-getters.h:43
43      MONO_CLASS_GETTER(m_class_get_class_kind, guint8, , MonoClass, class_kind)
(gdb) bt
#0  0x00007ffff739912c in m_class_get_class_kind (klass=0x100000002c8) at /home/bill/dev/runtime/src/mono/mono/metadata/class-getters.h:43
#1  0x00007ffff769fda5 in mono_class_is_ginst (klass=0x100000002c8) at /home/bill/dev/runtime/src/mono/mono/mini/../../mono/metadata/class-inlines.h:57
#2  0x00007ffff769fc16 in mono_get_generic_context_from_stack_frame (ji=0x5555557eaaf0, generic_info=0x5555557cc170) at /home/bill/dev/runtime/src/mono/mono/mini/mini-exceptions.c:862
#3  0x00007ffff76a0ac5 in get_method_from_stack_frame (ji=0x5555557eaaf0, generic_info=0x5555557cc170) at /home/bill/dev/runtime/src/mono/mono/mini/mini-exceptions.c:888
#4  0x00007ffff76a19c4 in ves_icall_get_frame_info (skip=-1, need_file_info=1 '\001', method=0x7fffffffd030, iloffset=0x7fffffffd028, native_offset=0x7fffffffd020, file=0x7fffffffd018, line=0x7fffffffd010,
    column=0x7fffffffd008) at /home/bill/dev/runtime/src/mono/mono/mini/mini-exceptions.c:1458