Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Workload] iOSSimulator condition will not import iOSSimulator AOT pack #53427

Closed
steveisok opened this issue May 28, 2021 · 1 comment · Fixed by #54821
Closed

[Workload] iOSSimulator condition will not import iOSSimulator AOT pack #53427

steveisok opened this issue May 28, 2021 · 1 comment · Fixed by #54821
Assignees
@steveisok
Labels
area-Infrastructure-mono
Milestone
6.0.0

Comments

@steveisok
Copy link
Member

In

runtime/src/mono/nuget/Microsoft.NET.Workload.Mono.Toolchain.Manifest/WorkloadManifest.targets

Line 31 in cb1f5ad

<ImportGroup Condition="'$(TargetPlatformIdentifier)' == 'iossimulator' and '$(RunAOTCompilation)' == 'true'">
, the TPI will always be iOS. We need to come up with another condition in order to make AOT on the simulator pack load.

Since AOT on the simulator is not something Xamarin iOS does, we can fix this later.

/cc @rolfbjarne @akoeplinger
@steveisok steveisok added this to the 6.0.0 milestone May 28, 2021
@ghost
Copy link

ghost commented May 28, 2021

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

In

runtime/src/mono/nuget/Microsoft.NET.Workload.Mono.Toolchain.Manifest/WorkloadManifest.targets

Line 31 in cb1f5ad

<ImportGroup Condition="'$(TargetPlatformIdentifier)' == 'iossimulator' and '$(RunAOTCompilation)' == 'true'">
, the TPI will always be iOS. We need to come up with another condition in order to make AOT on the simulator pack load.

Since AOT on the simulator is not something Xamarin iOS does, we can fix this later.

/cc @rolfbjarne @akoeplinger

Author: steveisok
Assignees: -
Labels:

area-Infrastructure-mono
Milestone: 6.0.0

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label May 28, 2021
@steveisok steveisok self-assigned this May 28, 2021
@steveisok steveisok removed the untriaged New issue has not been triaged by the area owner label Jun 28, 2021
steveisok pushed a commit to steveisok/runtime that referenced this issue Jun 28, 2021
Move iOS/tvOS simulator AOT imports in the Mono workload
3c2ea1d 
The condition on the import group for the iOS and tvOS simulators was not valid since iOS/tvOSSimulator is not a `TargetPlatformIdentifier`. To simplify, the simulator imports were moved under iOS/tvOS.

Fixes dotnet#53427
@steveisok steveisok mentioned this issue Jun 28, 2021
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Jun 28, 2021
stephentoub pushed a commit that referenced this issue Jun 28, 2021
@steveisok
Move iOS/tvOS simulator AOT imports in the Mono workload (#54821)
bde0322 
The condition on the import group for the iOS and tvOS simulators was not valid since iOS/tvOSSimulator is not a `TargetPlatformIdentifier`. To simplify, the simulator imports were moved under iOS/tvOS.

Fixes #53427

Co-authored-by: Steve Pfister <steve.pfister@microsoft.com>
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Jun 28, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jul 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@steveisok steveisok

Labels
area-Infrastructure-mono
Projects
None yet
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

Move iOS/tvOS simulator AOT imports in the Mono workload steveisok/runtime
1 participant
@steveisok