Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Microsoft.Extensions.Logging.Console.Tests fail on Android #50575

Closed
1 task
mdh1418 opened this issue Apr 1, 2021 · 2 comments · Fixed by #74349 or #74496
Closed
1 task

Microsoft.Extensions.Logging.Console.Tests fail on Android #50575

mdh1418 opened this issue Apr 1, 2021 · 2 comments · Fixed by #74349 or #74496
Assignees
@mkhamoyan
Labels
area-Extensions-Logging os-android
Milestone
Future

Comments

@mdh1418
Copy link
Member

mdh1418 commented Apr 1, 2021

One test from Microsoft.Extensions.Logging.Console.Tests fails on Android

  • Microsoft.Extensions.Logging.Console.Test.SimpleConsoleFormatterTests.Log_WritingScopes_LogsWithCorrectColorsWhenColorEnabled(colorBehavior: Default)

Based on CI runs from #50095
@mdh1418 mdh1418 added this to the 6.0.0 milestone Apr 1, 2021
@dotnet-issue-labeler dotnet-issue-labeler bot added area-System.Console untriaged New issue has not been triaged by the area owner labels Apr 1, 2021
@ghost
Copy link

ghost commented Apr 1, 2021

Tagging subscribers to this area: @carlossanlop
See info in area-owners.md if you want to be subscribed.

Issue Details

One test from Microsoft.Extensions.Logging.Console.Tests fails on Android

  • Microsoft.Extensions.Logging.Console.Test.SimpleConsoleFormatterTests.Log_WritingScopes_LogsWithCorrectColorsWhenColorEnabled(colorBehavior: Default)

Based on CI runs from #50095

Author: mdh1418
Assignees: -
Labels:

area-System.Console, os-android, untriaged
Milestone: 6.0.0

@ghost
Copy link

ghost commented Apr 2, 2021

Tagging subscribers to this area: @maryamariyan
See info in area-owners.md if you want to be subscribed.

Issue Details

One test from Microsoft.Extensions.Logging.Console.Tests fails on Android

  • Microsoft.Extensions.Logging.Console.Test.SimpleConsoleFormatterTests.Log_WritingScopes_LogsWithCorrectColorsWhenColorEnabled(colorBehavior: Default)

Based on CI runs from #50095

Author: mdh1418
Assignees: -
Labels:

area-Extensions-Logging, os-android, untriaged
Milestone: 6.0.0

@maryamariyan maryamariyan removed the untriaged New issue has not been triaged by the area owner label Apr 4, 2021
@maryamariyan maryamariyan modified the milestones: 6.0.0, Future Jul 22, 2021
mkhamoyan added a commit to mkhamoyan/runtime that referenced this issue Aug 22, 2022
@mkhamoyan
dotnet#50575 default case clor behaviour is enabled
ae0bdef
@mkhamoyan mkhamoyan mentioned this issue Aug 22, 2022
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Aug 22, 2022
mkhamoyan added a commit to mkhamoyan/runtime that referenced this issue Aug 23, 2022
@mkhamoyan
dotnet#50575 do the change only for android/applemobile
d17da80
mkhamoyan added a commit to mkhamoyan/runtime that referenced this issue Aug 23, 2022
@mkhamoyan
dotnet#50575 refactored
e62b3b2
mkhamoyan added a commit to mkhamoyan/runtime that referenced this issue Aug 23, 2022
@mkhamoyan
dotnet#50575 bring the switch to initial state
d34cf12
@mkhamoyan mkhamoyan self-assigned this Aug 23, 2022
mkhamoyan added a commit that referenced this issue Aug 23, 2022
@mkhamoyan
#50575 default case color behaviour is enabled (#74349)
ad366f2 
* #50575 color behaviour by default is enabled on android/applemobile
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Aug 23, 2022
mkhamoyan added a commit that referenced this issue Aug 24, 2022
@mkhamoyan
Revert "#50575 default case color behaviour is enabled (#74349)"
62b1457 
This reverts commit ad366f2.
@mkhamoyan mkhamoyan reopened this Aug 24, 2022
mkhamoyan added a commit that referenced this issue Aug 24, 2022
@mkhamoyan
Revert "#50575 default case color behaviour is enabled (#74349)" (#74485
474b2aa 
)

This reverts commit ad366f2.
mkhamoyan added a commit to mkhamoyan/runtime that referenced this issue Aug 24, 2022
@mkhamoyan
dotnet#50575 fcolorbehavior default should disable colors in android/…
05cde00 
…applemobile
@mkhamoyan mkhamoyan mentioned this issue Aug 24, 2022
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Aug 24, 2022
mkhamoyan added a commit to mkhamoyan/runtime that referenced this issue Aug 24, 2022
@mkhamoyan
dotnet#50575 make _isAndroidOrAppleMobile static field
237f75d
mkhamoyan added a commit to mkhamoyan/runtime that referenced this issue Aug 24, 2022
@mkhamoyan
dotnet#50575 aligning lines
54aa4f7
mkhamoyan added a commit to mkhamoyan/runtime that referenced this issue Aug 24, 2022
@mkhamoyan
dotnet#50575 added comment explaining why _isAndroidOrAppleMobile is …
3864d3b 
…needed
mkhamoyan added a commit that referenced this issue Aug 25, 2022
@mkhamoyan
#50575 colorbehavior default should disable colors in android/applemo…
ebdb045 
…bile (#74496)

* #50575 colorbehavior default should disable colors in android/applemobile
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Aug 25, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Sep 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mkhamoyan mkhamoyan

Labels
area-Extensions-Logging os-android
Projects
None yet
Milestone
Future
4 participants
@maryamariyan @jeffschwMSFT @mdh1418 @mkhamoyan