Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for open delegate for Nullable<> methods does not work on Mono interpreter #49839

Closed
davidwrighton opened this issue Mar 18, 2021 · 2 comments · Fixed by #55354
Closed

Support for open delegate for Nullable<> methods does not work on Mono interpreter #49839

davidwrighton opened this issue Mar 18, 2021 · 2 comments · Fixed by #55354
Assignees
@BrzVlad
Labels
area-Codegen-Interpreter-mono
Milestone
6.0.0

Comments

@davidwrighton
Copy link
Member

Description

The CreateDelegate10_Nullable_Method test introduced with pr #42837 does not work on the Mono interpreter.

Regression?

This is not a regression.
@dotnet-issue-labeler dotnet-issue-labeler bot added area-Codegen-Interpreter-mono untriaged New issue has not been triaged by the area owner labels Mar 18, 2021
@ghost
Copy link

ghost commented Mar 18, 2021

Tagging subscribers to this area: @BrzVlad
See info in area-owners.md if you want to be subscribed.

Issue Details

Description

The CreateDelegate10_Nullable_Method test introduced with pr #42837 does not work on the Mono interpreter.

Regression?

This is not a regression.

Author: davidwrighton
Assignees: -
Labels:

area-Codegen-Interpreter-mono, untriaged
Milestone: -

@lambdageek lambdageek added this to the 6.0.0 milestone Mar 19, 2021
@marek-safar marek-safar removed the untriaged New issue has not been triaged by the area owner label Mar 19, 2021
@SamMonoRT
Copy link
Member

Not the highest priority now. We'll take a look at it in May-June timeframe.

BrzVlad added a commit to BrzVlad/runtime that referenced this issue Jul 8, 2021
@BrzVlad
[interp] Fix open delegates used with virtual methods of valuetypes
533b316 
We were trying to resolve the virtual method on the this pointer (which is a managed pointer and not an object). If the delegate target method is declared on a valuetype, the method does not need resolving.

Fixes dotnet#49839
@BrzVlad BrzVlad mentioned this issue Jul 8, 2021
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Jul 8, 2021
BrzVlad added a commit that referenced this issue Jul 10, 2021
@BrzVlad
[interp] Fix open delegates used with virtual methods of valuetypes (#…
1ff0b50 
…55354)

* [interp] Fix open delegates used with virtual methods of valuetypes

We were trying to resolve the virtual method on the this pointer (which is a managed pointer and not an object). If the delegate target method is declared on a valuetype, the method does not need resolving.

Fixes #49839

* Re-enable tests
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Jul 10, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Aug 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@BrzVlad BrzVlad

Labels
area-Codegen-Interpreter-mono
Projects
None yet
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

[interp] Fix open delegates used with virtual methods of valuetypes BrzVlad/runtime
5 participants
@marek-safar @lambdageek @BrzVlad @davidwrighton @SamMonoRT