Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test failed : threading.SetThreadDescription.test1 #48496

Closed
VincentBu opened this issue Feb 19, 2021 · 9 comments · Fixed by #48932
Closed

Test failed : threading.SetThreadDescription.test1 #48496

VincentBu opened this issue Feb 19, 2021 · 9 comments · Fixed by #48932
Labels
arch-x64 area-PAL-coreclr os-linux Linux OS (any supported distro) untriaged New issue has not been triaged by the area owner

Comments

@VincentBu
Copy link
Contributor

Run: runtime-coreclr outerloop 20210218.4

Failed test:

CoreCLR Linux x64 Checked no_tiered_compilation @ (Alpine.312.Amd64.Open)ubuntu.1604.amd64.open@mcr.microsoft.com/dotnet-buildtools/prereqs:alpine-3.12-helix-20200602002622-e06dc59

 -threading.SetThreadDescription.test1

Error message:

paltests <PrintPalTests|TestName>
Either print list of all paltests by passing PrintPalTests, or run a single PAL test.
@VincentBu VincentBu added os-linux Linux OS (any supported distro) arch-x64 labels Feb 19, 2021
@dotnet-issue-labeler dotnet-issue-labeler bot added area-PAL-coreclr untriaged New issue has not been triaged by the area owner labels Feb 19, 2021
@danmoseley
Copy link
Member

Possibly related to #47465

@jkotas
Copy link
Member

jkotas commented Feb 19, 2021

@esoros @am11 Could you please look into fixing this test on Alpine?

@esoros
Copy link
Contributor

esoros commented Feb 19, 2021

Yeah I can take a look at this - I don’t think that alpine supports pthread_setname_np but I need to verify that

@esoros
Copy link
Contributor

esoros commented Feb 24, 2021

@am11 @jkotas Not to spin around in circles but are you fine with removing the tests? I don't see a compiler pragma for musl and don't have a goof way off the top of my head to conditionally run these tests.

@jkotas
Copy link
Member

jkotas commented Feb 24, 2021

I would be fine with it.

@am11
Copy link
Member

am11 commented Feb 24, 2021

This was the first conditionally compiled PAL test.

I don't see a compiler pragma for musl

The test is already excluded from compilation on Alpine (which is why PAL tests are building on Alpine without error). During the test run, however, this line is causing issue if the test name (from .txt file) was not found in test binaries:

return PrintUsage(argc, argv);
fix is to replace this line with a simple skip message: printf("Skipping test '%s' because its binary was not found on this platform.\n", argv[1]); return 0; for any conditionally-compiled test.

@VincentBu
Copy link
Contributor Author

Failed again in runtime-coreclr outerloop 20210228.1

Failed test:

R2R Linux x64 Checked @ (Alpine.312.Amd64.Open)ubuntu.1604.amd64.open@mcr.microsoft.com/dotnet-buildtools/prereqs:alpine-3.12-helix-20200602002622-e06dc59
 
-threading.SetThreadDescription.test1

Error message:

paltests <PrintPalTests|TestName>
Either print list of all paltests by passing PrintPalTests, or run a single PAL test.

@BruceForstall
Copy link
Member

@am11 @esoros @jkotas This test has been failing every coreclr outerloop job since it was introduced 11 days ago (https://dev.azure.com/dnceng/public/_build?definitionId=655&_a=summary).

Can we either get it (1) disabled (for just Alpine, or for all platforms), (2) fixed, or (3) deleted ASAP?

jkotas added a commit to jkotas/runtime that referenced this issue Mar 2, 2021
This partially reverts commit 77c939c.

Fixes dotnet#48496
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Mar 2, 2021
@jkotas
Copy link
Member

jkotas commented Mar 2, 2021

#48932

jkotas added a commit that referenced this issue Mar 2, 2021
This partially reverts commit 77c939c.

Fixes #48496
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Mar 2, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Apr 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-x64 area-PAL-coreclr os-linux Linux OS (any supported distro) untriaged New issue has not been triaged by the area owner
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants