Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need a way to ignore build configurations when library is inbox #23972

Closed
weshaggard opened this issue Oct 26, 2017 · 7 comments · Fixed by #35606 or #39842
Closed

Need a way to ignore build configurations when library is inbox #23972

weshaggard opened this issue Oct 26, 2017 · 7 comments · Fixed by #35606 or #39842
Assignees
Labels
area-Infrastructure-libraries disabled-test The test is disabled in source code against the issue
Milestone

Comments

@weshaggard
Copy link
Member

For libraries like DirectoryServices which are inbox on a framework (https://github.com/dotnet/corefx/blob/master/src/System.DirectoryServices/pkg/System.DirectoryServices.pkgproj#L10) and only have a netstandard configuration without a netfx configuration because it shares the same identity as desktop, we need a way to tell our build system to ignore the netstandard configuration when building the netfx vertical. Without that we will end up selecting the netstandard asset and building and testing that when doing our netfx vertical testing.

We can probably add a new property called something like IgnoreBuildConfigurations or InboxOnFramework and teach our configuration system (likely somewhere in https://github.com/dotnet/corefx/blob/master/buildvertical.targets#L70) to filter out and skip such configurations.

@safern
Copy link
Member

safern commented Oct 26, 2017

I definitely think we should get this fixed as part of the Compat pack effort to be able to have the tests running against the inbox netfx assemblies and catch differences in behavior. I've started running them locally by manually removing the netstandard assemblies from the runtime and testhost netfx folder so that it is linked to the GAC assembly.

@safern
Copy link
Member

safern commented Feb 1, 2018

This is done. We now can do this and we have done this for all the projects in the Compat pack. We're just missing, System.ComponentModel.Composition which has internalsVisibleTo and a lot of internal testing. Which when testing vs inbox assembly we can't access. I have an issue tracking that: https://github.com/dotnet/corefx/issues/25781

@safern safern closed this as completed Feb 1, 2018
@stephentoub
Copy link
Member

@safern, there are ~180 tests with ActiveIssue against this issue.

@stephentoub stephentoub reopened this Jan 23, 2020
@safern
Copy link
Member

safern commented Jan 23, 2020

Ok, I'll take a look at why and fix it accordingly.

@msftgits msftgits transferred this issue from dotnet/corefx Jan 31, 2020
@msftgits msftgits added this to the 2.1.0 milestone Jan 31, 2020
@maryamariyan maryamariyan added the untriaged New issue has not been triaged by the area owner label Feb 23, 2020
@jkotas jkotas modified the milestones: 2.1.0, 5.0 Mar 1, 2020
@ViktorHofer
Copy link
Member

ping @safern. Would love to close this again, can you please scan tests and remove/diagnose the active issues?

@safern
Copy link
Member

safern commented Apr 17, 2020

Yeah. I just have had other priorities. I just wrote this down on my pending tasks to not forget. Will get to it in the coming days, thanks.

@ViktorHofer
Copy link
Member

@safern I wouldn't spend too much time on this as with #35606 we will stop using the RefPath for anything != NetCoreAppCurrent and I'm considering getting rid of the RuntimePath for OOB libraries
as well and build them app-local instead, which is the way they are being used by customers. I talked about this with @ericstj in the past.

As an example, a .NET Framework Test Library would either use a P2P (to the ref&impl, if the live built assets should be used) or a simple name reference (if the assembly should be resolved from the GAC).

@ericstj ericstj removed the untriaged New issue has not been triaged by the area owner label Jun 23, 2020
@ViktorHofer ViktorHofer modified the milestones: 5.0.0, Future Jun 23, 2020
ViktorHofer added a commit to ViktorHofer/runtime that referenced this issue Jul 23, 2020
@ViktorHofer ViktorHofer reopened this Jul 23, 2020
Jacksondr5 pushed a commit to Jacksondr5/runtime that referenced this issue Aug 10, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Infrastructure-libraries disabled-test The test is disabled in source code against the issue
Projects
None yet
8 participants