Use ValueArray as inline storage in MethodCallExpression nodes.

dotnet · Oct 27, 2021 · 88c2c84 · 88c2c84
1 parent 4040fad
commit 88c2c84
Show file tree

Hide file tree

Showing 6 changed files with 93 additions and 321 deletions.
diff --git a/src/libraries/System.Linq.Expressions/src/System.Linq.Expressions.csproj b/src/libraries/System.Linq.Expressions/src/System.Linq.Expressions.csproj
@@ -217,4 +217,7 @@
     <Reference Include="System.Runtime.Extensions" />
     <Reference Include="System.Threading" />
   </ItemGroup>
+  <ItemGroup>
+    <ProjectReference Include="$(LibrariesProjectRoot)System.Runtime.CompilerServices.Unsafe\src\System.Runtime.CompilerServices.Unsafe.ilproj" />
+  </ItemGroup>
 </Project>
diff --git a/src/libraries/System.Linq.Expressions/src/System/Linq/Expressions/BlockExpression.cs b/src/libraries/System.Linq.Expressions/src/System/Linq/Expressions/BlockExpression.cs
@@ -312,6 +312,8 @@ internal override BlockExpression Rewrite(ReadOnlyCollection<ParameterExpression
         }
     }
 
+    // TODO: the whole family of classes can be simplified by using inline storage.
+
     internal sealed class Block4 : BlockExpression
     {
         private object _arg0;                               // storage for the 1st argument or a read-only collection.  See IArgumentProvider

diff --git a/src/libraries/System.Linq.Expressions/src/System/Linq/Expressions/DynamicExpression.cs b/src/libraries/System.Linq.Expressions/src/System/Linq/Expressions/DynamicExpression.cs
@@ -725,6 +725,8 @@ internal TypedDynamicExpression3(Type retType, Type delegateType, CallSiteBinder
         public sealed override Type Type { get; }
     }
 
+    // TODO: the whole family of classes can be simplified by using inline storage.
+
     internal class DynamicExpression4 : DynamicExpression, IArgumentProvider
     {
         private object _arg0;                               // storage for the 1st argument or a read-only collection.  See IArgumentProvider for more info.

diff --git a/src/libraries/System.Linq.Expressions/src/System/Linq/Expressions/InvocationExpression.cs b/src/libraries/System.Linq.Expressions/src/System/Linq/Expressions/InvocationExpression.cs
@@ -344,6 +344,8 @@ internal override InvocationExpression Rewrite(Expression lambda, Expression[]?
         }
     }
 
+    // TODO: the whole family of classes can be simplified by using inline storage.
+
     internal sealed class InvocationExpression5 : InvocationExpression
     {
         private object _arg0;               // storage for the 1st argument or a read-only collection.  See IArgumentProvider
-Original file line number
+Diff line change
@@ Expand Up @@
             }
         }
+        // TODO: the whole family of classes can be simplified by using inline storage.
         internal sealed class Block4 : BlockExpression
         {
             private object _arg0;                               // storage for the 1st argument or a read-only collection.  See IArgumentProvider
@@ Expand Down @@