Address review comments.

dotnet · Jun 21, 2023 · 2f6889a · 2f6889a
1 parent 1f3a533
commit 2f6889a
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 14 deletions.
diff --git a/src/libraries/System.Private.CoreLib/src/System/Numerics/BitOperations.cs b/src/libraries/System.Private.CoreLib/src/System/Numerics/BitOperations.cs
@@ -980,7 +980,7 @@ internal static uint FlipBit(uint value, int index)
         [MethodImpl(MethodImplOptions.AggressiveInlining)]
         internal static ulong FlipBit(ulong value, int index)
         {
-            return value ^ (1UL << index);
+            return value ^ (1ul << index);
         }
     }
 }
diff --git a/src/libraries/System.Private.CoreLib/src/System/SpanHelpers.T.cs b/src/libraries/System.Private.CoreLib/src/System/SpanHelpers.T.cs
@@ -3792,19 +3792,6 @@ public static int CountValueType<T>(ref T current, T value, int length) where T
 
                         return count;
                     }
-                    // TODO : Verify this makes sense
-                    /*if (remaining > Vector256<T>.Count / 2)
-                    {
-                        Vector256<T> targetVector256 = Vector256.Create(value);
-                        uint mask = Vector256.Equals(Vector256.LoadUnsafe(ref oneVectorAwayFromEnd), targetVector256).ExtractMostSignificantBits();
-
-                        // The mask contains some elements that may be double-checked, so shift them away in order to get the correct pop-count.
-                        uint overlaps = (uint)Vector256<T>.Count - remaining;
-                        mask >>= (int)overlaps;
-                        count += BitOperations.PopCount(mask);
-
-                        return count;
-                    }*/
                 }
                 else if (Vector256.IsHardwareAccelerated && length >= Vector256<T>.Count)
                 {