Disallow InlineArray attribute on a record struct type.
#74072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcouv
reviewed
Jun 20, 2024
| @@ -7983,4 +7983,7 @@ To remove the warning, you can use /reference instead (set the Embed Interop Typ | |||
| <data name="IDS_FeatureAllowsRefStructConstraint" xml:space="preserve"> | |||
| <value>allows ref struct constraint</value> | |||
| </data> | |||
| <data name="ERR_InlineArrayAttributeOnRecord" xml:space="preserve"> | |||
| <value>Attribute 'System.Runtime.CompilerServices.InlineArray' cannot be applied to a record struct.</value> | |||
There was a problem hiding this comment.
Should we also add an entry to breaking changes doc?
jcouv
approved these changes
Jun 20, 2024
333fred
approved these changes
Jun 20, 2024
jjonescz
approved these changes
Jun 20, 2024
|
|
||
| ## InlineArray attribute on a record struct type is no longer allowed. | ||
|
|
||
| ***Introduced in Visual Studio 2022 version 17.12*** |
There was a problem hiding this comment.
I think if you merge this week it will go into VS 17.11, but that's probably not very important.
This was referenced Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #73504.