Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not generate obsolete Exception constructor #72671

Merged
merged 3 commits into from
Mar 24, 2024
Merged

Do not generate obsolete Exception constructor #72671

merged 3 commits into from
Mar 24, 2024

Conversation

DoctorKrolic
Copy link
Contributor

Fixes: #72552

@DoctorKrolic DoctorKrolic requested a review from a team as a code owner March 22, 2024 17:09
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Mar 22, 2024
@dotnet-policy-service dotnet-policy-service bot added the Community The pull request was submitted by a contributor who is not a Microsoft employee. label Mar 22, 2024
@CyrusNajmabadi
Copy link
Member

Thanks!

@DoctorKrolic
Copy link
Contributor Author

@CyrusNajmabadi It seems that the CI is failing consistently on a one specific compiler-related test. I also see this error in my other PR. So there might be a CI issue, which needs attention (and it is CI-only since it fails in 1 specific environment, while passes in others and locally)

@CyrusNajmabadi
Copy link
Member

@DoctorKrolic known issue.

@CyrusNajmabadi CyrusNajmabadi merged commit 3118dbe into dotnet:main Mar 24, 2024
27 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Mar 24, 2024
@DoctorKrolic DoctorKrolic deleted the no-obsolete-constructor branch March 24, 2024 09:05
This was referenced Mar 25, 2024
Closed
Closed
Closed
@RikkiGibson RikkiGibson modified the milestones: Next, 17.10 P3 Mar 25, 2024
@dotnet-bot dotnet-bot mentioned this pull request Mar 26, 2024
Closed
@DoctorKrolic DoctorKrolic mentioned this pull request May 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharwell sharwell sharwell approved these changes

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi approved these changes

Assignees
No one assigned
Labels
Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee. untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
17.10 P3
Development

Successfully merging this pull request may close these issues.

Quick actions and refactoring - generate exception class creates obsolete code
4 participants
@DoctorKrolic @CyrusNajmabadi @sharwell @RikkiGibson