Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary component load #72647

Merged
merged 1 commit into from
Mar 21, 2024
Merged

Remove unnecessary component load #72647

merged 1 commit into from
Mar 21, 2024

Conversation

CyrusNajmabadi
Copy link
Member

Roslyn no longer uses the task-status-center (was used in solution crawler before). No need to try to load that component.

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner March 21, 2024 18:51
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Mar 21, 2024
@CyrusNajmabadi CyrusNajmabadi requested a review from ToddGrun March 21, 2024 18:51
genlu
genlu approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member

@genlu genlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust your statement of this not being used for things other than solution crawler :)

@CyrusNajmabadi CyrusNajmabadi merged commit be3730e into dotnet:main Mar 21, 2024
25 of 27 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Mar 21, 2024
@CyrusNajmabadi CyrusNajmabadi deleted the taskStatusCenter branch March 21, 2024 20:23
@RikkiGibson RikkiGibson modified the milestones: Next, 17.10 P3 Mar 25, 2024
@dotnet-bot dotnet-bot mentioned this pull request Mar 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@genlu genlu genlu approved these changes

@ToddGrun ToddGrun Awaiting requested review from ToddGrun

Assignees
No one assigned
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
17.10 P3
Development

Successfully merging this pull request may close these issues.
3 participants
@CyrusNajmabadi @genlu @RikkiGibson