Disable slow source generator 'JSImportGenerator' for Roslyn builds #67944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyrusNajmabadi
approved these changes
Apr 24, 2023
jaredpar
reviewed
Apr 24, 2023
| <!-- Workaround for https://github.com/dotnet/runtime/pull/84936 --> | ||
| <Target Name="ExcludeSlowJSImportGenerator" AfterTargets="ResolveTargetingPackAssets"> | ||
| <ItemGroup> | ||
| <Analyzer Remove="@(Analyzer)" Condition="'%(FileName)' == 'Microsoft.Interop.JavaScript.JSImportGenerator' AND '%(Analyzer.NuGetPackageId)' == 'Microsoft.NETCore.App.Ref'" /> |
There was a problem hiding this comment.
Why do we need the second half of this condition here? Would assume the first is sufficient.
There was a problem hiding this comment.
It seemed more specific, but either way should work fine.
jaredpar
approved these changes
Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround for dotnet/runtime#84936